Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fund form #4370

Merged
merged 15 commits into from
May 13, 2019
Merged

Fund form #4370

merged 15 commits into from
May 13, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented May 7, 2019

Description

New form design

Refers/Fixes

#4331

Testing

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #4370 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4370   +/-   ##
=======================================
  Coverage   30.19%   30.19%           
=======================================
  Files         209      209           
  Lines       16790    16790           
  Branches     2249     2249           
=======================================
  Hits         5070     5070           
  Misses      11527    11527           
  Partials      193      193
Impacted Files Coverage Δ
app/dashboard/views.py 14.25% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8f5c1...e7f8341. Read the comment docs.

@danlipert
Copy link
Contributor

@octavioamu what does this PR do?

@octavioamu
Copy link
Contributor Author

@danlipert is the new form design

}
return;
}
const setPrivateForm = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeee

@thelostone-mc
Copy link
Member

thelostone-mc commented May 12, 2019

@danlipert It's eventually supposed to be this

@octavioamu is this good for review ?

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bounty flow looks solid ! Looks super nice ❤️

@thelostone-mc thelostone-mc merged commit d83aa40 into master May 13, 2019
@thelostone-mc thelostone-mc deleted the fund-form branch July 4, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants