grant/detail : rebirth #4366
grant/detail : rebirth #4366
Conversation
thelostone-mc
force-pushed
the
grant_detail
branch
from
e0f7a68 to
71a5392
Compare
- updated page as per new design - split detail into detail/info + detail/updates - updated button styling to ensure uniformity - refactor + remove deadcode
thelostone-mc
force-pushed
the
grant_detail
branch
from
71a5392 to
8f9524d
Compare
| {% else %} | ||
|
|
||
| <a href="{% url 'grants:fund' grant.id grant.slug %}"> | ||
| <button class="btn btn-gc-blue button--full no-shadow font-weight-bold py-3">{% trans "Fund this Grant" %}</button> |
There was a problem hiding this comment.
maybe we can just use .btn-lg class will increase the radius , font size, line-height and padding
There was a problem hiding this comment.
Hmm that would involve we updating the .btn-lg css cause out of the box it looks a lil meh
original (matches design)
using btn-lg
.
There was a problem hiding this comment.
What Im doing is just using what we have unless is a component update, then I update the component.
Codecov Report
@@ Coverage Diff @@
## master #4366 +/- ##
=======================================
Coverage 30.19% 30.19%
=======================================
Files 209 209
Lines 16790 16790
Branches 2249 2249
=======================================
Hits 5070 5070
Misses 11527 11527
Partials 193 193
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4366 +/- ##
==========================================
- Coverage 30.19% 30.16% -0.04%
==========================================
Files 209 209
Lines 16790 16790
Branches 2249 2249
==========================================
- Hits 5070 5064 -6
- Misses 11527 11533 +6
Partials 193 193
Continue to review full report at Codecov.
|
| position: relative; | ||
| } | ||
|
|
||
| #CLR_banner .clr-text { |
There was a problem hiding this comment.
Can't do this cause it has diff behavior on a diff screen 😅
thelostone-mc
force-pushed
the
grant_detail
branch
from
79a3595 to
4ee7c47
Compare
app/assets/v2/css/grants/detail.css
Outdated
| } | ||
|
|
||
| .summary-container { | ||
| background-color: white; |
|
|
||
| #grant-profile-tabs { | ||
| text-align: center; | ||
| border-bottom: none; |
There was a problem hiding this comment.
border-bottom-0
text-center
thelostone-mc
force-pushed
the
grant_detail
branch
from
ef9fa0e to
3e46eb0
Compare
Description
NOTES: donation bars will be built out in a follow-up PR
Refers/Fixes
Testing
DEMO: https://embed.vidyard.com/share/cLrED9vprW2CqFCMa9RaDi?