Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add network to filters #4351

Merged
merged 2 commits into from
May 2, 2019
Merged

add network to filters #4351

merged 2 commits into from
May 2, 2019

Conversation

octavioamu
Copy link
Contributor

Description
Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #4351 into master will decrease coverage by <.01%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4351      +/-   ##
==========================================
- Coverage    30.2%   30.19%   -0.01%     
==========================================
  Files         209      209              
  Lines       16784    16790       +6     
  Branches     2247     2249       +2     
==========================================
+ Hits         5069     5070       +1     
- Misses      11523    11527       +4     
- Partials      192      193       +1
Impacted Files Coverage Δ
app/dashboard/views.py 14.25% <12.5%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ddd8d...a37fb7d. Read the comment docs.

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #4351 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4351      +/-   ##
==========================================
- Coverage    30.2%   30.19%   -0.01%     
==========================================
  Files         209      209              
  Lines       16784    16787       +3     
  Branches     2247     2248       +1     
==========================================
  Hits         5069     5069              
- Misses      11523    11526       +3     
  Partials      192      192
Impacted Files Coverage Δ
app/dashboard/views.py 14.2% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ddd8d...e755ce7. Read the comment docs.

@danlipert danlipert merged commit 9b6cdc5 into master May 2, 2019
@thelostone-mc thelostone-mc deleted the fix/network-filter branch July 4, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants