#4321 Update Links for Marketing #4341
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4341 +/- ##
==========================================
- Coverage 30.2% 30.16% -0.04%
==========================================
Files 209 209
Lines 16776 16776
Branches 2245 2245
==========================================
- Hits 5067 5061 -6
- Misses 11519 11525 +6
Partials 190 190
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4341 +/- ##
=======================================
Coverage 30.19% 30.19%
=======================================
Files 209 209
Lines 16790 16790
Branches 2249 2249
=======================================
Hits 5070 5070
Misses 11527 11527
Partials 193 193
Continue to review full report at Codecov.
|
|
@SaptakS Thanks for checking, please check again, better now? |
| <a href="/contributor/design">Design</a>, | ||
| <a href="/contributor/html">HTML</a>, | ||
| <a href="/contributor/ruby">Ruby</a>, | ||
| <a href="/contributor/css">CSS</a>, |
There was a problem hiding this comment.
Could we pass this from the backend as an array and simply loop through it here ?
There was a problem hiding this comment.
In theory yes, I also thought of that, but we'd need to create a new either table or json in python.
What route do you prefer? Table for editing live, or json/hardcoded json to have a deploy cycle?
There was a problem hiding this comment.
Harcoded Json for now would work 🙌
There was a problem hiding this comment.
@kuhnchris You can just send it as part of the template params as an array of strings.
There was a problem hiding this comment.
I know, just wanting to make sure that's reaaaaaally what you want. But sure, i'll add it.
There was a problem hiding this comment.
This whole bounties/contributor stuff is a whole lot of 💩 .
we cannot use 'url' with that, since it's not a registered route but somehow dynamically generated.
django.urls.exceptions.NoReverseMatch: Reverse for 'bounties/contributor' not found. 'bounties/contributor' is not a valid view function or pattern name.
{% for subject in contributor_list %}
<a href="{% url 'bounties/contributor' %}"{=subject.link=}>{=subject.text=}</a>, <- neither
{% endfor %}
<a href="{% url 'contributor/python' %}">Python</a>, <- nor this
<a href="{% url 'contributor' %}/python">Python</a>, <- nor this
Please advice.
There was a problem hiding this comment.
It's not whole lot of 💩 , you are just writing it wrong. The code is supposed to be:
{% for subject in contributor_list %}
<a href="{% url 'contributor_bounties' tech_stack=subject.link %}">{{ subject.text }}</a>, <- neither
{% endfor %}
This is assuming that subject.link is /python and subject.text is Python
I am not sure where you got the above syntax from. I would really advice you to go through this documentation to learn django templating: https://docs.djangoproject.com/en/2.2/topics/templates/
There was a problem hiding this comment.
@SaptakS Thanks for the heads up, still thinking that contributor + tech_stack is 💩 (especially cause I need to comment views.py L567-568 just to make it work on a local dev environment, else those pages 404) , but I couldn't care less.
Also, thanks for relinking me to the template documentation, I tried to get the url '' part working so I tried working with various types of {= {% ... to ensure it wasn't me fucking this up.
Committed, please check, worked over here.
Just letting you know for some reason you dropped "Go" but it's on the infographics on the left, so I might reconsider dropping it. @PixelantDesign
There was a problem hiding this comment.
^ @PixelantDesign let us know if that needs to be updated
Description
See #4321
Refers/Fixes
Fixes: #4321
Testing