Remove button class disabled and css for disabled button

[shad-k]

Description

Removed the addClass('disabled') for button and css for button:disabled selector.

Refers/Fixes

Fixes #4315

[codecov]

Codecov Report

Merging #4337 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4337      +/-   ##
==========================================
- Coverage    30.2%   30.16%   -0.04%     
==========================================
  Files         209      209              
  Lines       16776    16776              
  Branches     2245     2245              
==========================================
- Hits         5067     5061       -6     
- Misses      11519    11525       +6     
  Partials      190      190

Impacted Files	Coverage Δ
app/dashboard/embed.py	28.16% <0%> (-3.45%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1037a2c...670d4bc. Read the comment docs.

[codecov]

Codecov Report

Merging #4337 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4337      +/-   ##
==========================================
- Coverage    30.2%   30.16%   -0.04%     
==========================================
  Files         209      209              
  Lines       16776    16776              
  Branches     2245     2245              
==========================================
- Hits         5067     5061       -6     
- Misses      11519    11525       +6     
  Partials      190      190

Impacted Files	Coverage Δ
app/dashboard/embed.py	28.16% <0%> (-3.45%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1037a2c...670d4bc. Read the comment docs.

[owocki]

the button should only be disabled if the validation fails. this just removes the disabled button in all cases..

[shad-k]

the button should only be disabled if the validation fails. this just removes the disabled button in all cases..

@owocki I have only removed the button:disabled selector, the button.disabled more specific selector is still there. So the disabled button still exists and the button is disabled when the validations are not met.

[owocki]

thanks; how did you test? i noticed you left out the 'Testing' section of the template...

[shad-k]

thanks; how did you test? i noticed you left out the 'Testing' section of the template...

I ran the tests already written but haven't written any new tests for this. Rest was mostly manual.

[owocki]

ok so you tested the validation working + not working states on gitcoin.co/new on your local @shad-k ?

@danlipert @thelostone-mc code LGTM; let me know what u think

[shad-k]

@owocki yes

[thelostone-mc]

LGTM 🙌