Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fe filters users #4311

Merged
merged 14 commits into from
May 2, 2019
Merged

Fe filters users #4311

merged 14 commits into from
May 2, 2019

Conversation

octavioamu
Copy link
Contributor

Description
Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #4311 into master will decrease coverage by 0.03%.
The diff coverage is 35.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4311      +/-   ##
==========================================
- Coverage   30.12%   30.08%   -0.04%     
==========================================
  Files         209      209              
  Lines       16738    17039     +301     
  Branches     2239     2307      +68     
==========================================
+ Hits         5042     5127      +85     
- Misses      11515    11713     +198     
- Partials      181      199      +18
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
app/dashboard/models.py 56.57% <100%> (+0.77%) ⬆️
app/dashboard/views.py 14.16% <34.21%> (+0.57%) ⬆️
app/grants/views.py 13.78% <0%> (-0.93%) ⬇️
app/kudos/views.py 21.77% <0%> (-0.07%) ⬇️
app/retail/views.py 31.04% <0%> (+1.43%) ⬆️
app/retail/emails.py 23.17% <0%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b9b2f7...131a04b. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #4311 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4311      +/-   ##
=========================================
- Coverage    30.2%   30.2%   -0.01%     
=========================================
  Files         209     209              
  Lines       16776   16784       +8     
  Branches     2245    2247       +2     
=========================================
+ Hits         5067    5069       +2     
- Misses      11519   11523       +4     
- Partials      190     192       +2
Impacted Files Coverage Δ
app/dashboard/views.py 14.23% <40%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e889a69...c4fe3fd. Read the comment docs.

@octavioamu octavioamu merged commit 54ddd8d into master May 2, 2019
@thelostone-mc thelostone-mc deleted the fe-filters-users branch July 4, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants