Fix: https://github.com/gitcoinco/web/issues/3762

[speedyFixer]

Description

This PR avoids failed subscriptions to be listed in the All Activity tab under Inactive subscriptions.

Refers/Fixes

Fixes: #3762

Testing

I did add tests because It's a fix (I tested manually), do you have any suggestion for some type of automated test?

[codecov]

Codecov Report

Merging #4288 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4288   +/-   ##
=======================================
  Coverage   30.13%   30.13%           
=======================================
  Files         209      209           
  Lines       16729    16729           
  Branches     2237     2237           
=======================================
  Hits         5041     5041           
  Misses      11507    11507           
  Partials      181      181

Impacted Files	Coverage Δ
app/grants/views.py	14.87% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c138f42...1907180. Read the comment docs.

[codecov]

Codecov Report

Merging #4288 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4288      +/-   ##
==========================================
- Coverage   30.19%   30.16%   -0.04%     
==========================================
  Files         209      209              
  Lines       16790    16790              
  Branches     2249     2249              
==========================================
- Hits         5070     5064       -6     
- Misses      11527    11533       +6     
  Partials      193      193

Impacted Files	Coverage Δ
app/grants/views.py	14.71% <0%> (ø)	⬆️
app/dashboard/embed.py	28.16% <0%> (-3.45%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a21815...3ff3884. Read the comment docs.

[danlipert]

@speedyFixer This is a pretty simple fix, so probably not necessary but for the future, you can add a unit test where you would create some grant subscriptions, then send a mock request to the grant details and make sure the returned data is what you would expect. You can find a simple example at https://github.com/gitcoinco/web/blob/master/app/dashboard/tests/test_users_list.py

[speedyFixer]

Thanks, I will keep in mind!