bug: handle where fee is 0 for bounty creation + increase funding #4285
Conversation
- updated code to hide fee section when fee is 0 & update content as needed. - avoid extra metamask popup for fee when fee is 0 - code refactor + css prettify
- updated code to hide fee section when fee is 0 & update content as needed. - avoid extra metamask popup for fee when fee is 0 - code refactor + css prettify
thelostone-mc
added
bug
thelostone-mc
changed the title
thelostone-mc
force-pushed
the
dynamic_fee
branch
from
c670e7b to
fecfeb5
Compare
Codecov Report
@@ Coverage Diff @@
## master #4285 +/- ##
======================================
Coverage 30.2% 30.2%
======================================
Files 209 209
Lines 16776 16776
Branches 2245 2245
======================================
Hits 5067 5067
Misses 11519 11519
Partials 190 190Continue to review full report at Codecov.
|
| @@ -36,7 +39,7 @@ $(document).ready(function() { | |||
| var denomSelect = $('select[name=denomination]'); | |||
|
|
|||
| localStorage['tokenAddress'] = denomSelect.data('tokenAddress'); | |||
| localStorage['amount'] = 0; | |||
| localStorage['amount'] = 0.01; | |||
There was a problem hiding this comment.
What does this change do?
There was a problem hiding this comment.
This ensures that the min amount is set to 0.01 as opposed to 0.
I originally updated on the html tag but the value here over-writes that, so had to udpate this too
In Increase funding amount shouldn't be set to 0 during submit.
If the amount is defaulted 0 -> the fee banner doesn't make sense cause it would say we charge 10% fee which is 0 :P
we set default amount to > 0 so that we don't show 10% fee which equates to 0.
| if (error) { | ||
| _alert({ message: gettext('Unable to pay bounty fee. Please try again.') }, 'error'); | ||
| } else { | ||
| // TODO: Save txnId + feeamount to bounty; |
There was a problem hiding this comment.
does this TODO still need to be added?
There was a problem hiding this comment.
This would be a separate task!
This would involve updating the bounty model / creating a new model to keep track of the fees.
I had brought this up when we originally built out fee%.
As of now we have no means to store and track it.
Here I've simple reorganized the code
need to evaluate if it would sense to keep fee in it's model and map bounties and other produxts to it. cc @owocki
|
@danlipert fixed up the typo + updated the event for no fee scenario |
thelostone-mc
force-pushed
the
dynamic_fee
branch
from
1c5f974 to
80c4a04
Compare
Description
This PR ensures that bounty creation and increase funding both work as expected when fee is set to 0.
The fee section is hidden when the fee is set to 0, that way the user doesn't see the banner making it less confusing. The total amount, however, states we charge no fees to make the user know that we are not charging them anything extra. The same thing in increase funding looks like THIS
Getting a lil more detailed
as needed.
Tests Done
Bounty creation
Bounty creation
Yes I tested this like a crazy person.
img: see here
cc @frankchen07