bounty/fee: fixes formula + css cleanup + makes fee editable #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4244 +/- ##
==========================================
+ Coverage 30.13% 30.13% +<.01%
==========================================
Files 209 209
Lines 16692 16694 +2
Branches 2230 2230
==========================================
+ Hits 5030 5031 +1
- Misses 11481 11482 +1
Partials 181 181
Continue to review full report at Codecov.
|
octavioamu
previously approved these changes
Apr 23, 2019
thelostone-mc
commented
Apr 23, 2019
app/assets/v2/js/pages/new_bounty.js
Outdated
| @@ -624,6 +624,27 @@ $(window).on('load', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| var check_balance_and_alert_user_if_not_enough = function(tokenAddress, amount) { | |||
There was a problem hiding this comment.
should we try and reuse the one in shared.js @danlipert ?
There was a problem hiding this comment.
@thelostone-mc yeah I think so, its just one line difference essentially
octavioamu
previously approved these changes
Apr 24, 2019
danlipert
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After fix it looks LIKE THIS
No change in behavior but will help when dynamic fee PR is being built out