Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #4238

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Update PULL_REQUEST_TEMPLATE.md #4238

merged 1 commit into from
Apr 22, 2019

Conversation

thelostone-mc
Copy link
Member

Description
  • updated PR template to make it easier to raise PRs

cc @danlipert

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #4238 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4238      +/-   ##
==========================================
- Coverage   30.28%   30.24%   -0.05%     
==========================================
  Files         209      209              
  Lines       16604    16604              
  Branches     2222     2222              
==========================================
- Hits         5029     5022       -7     
- Misses      11391    11401      +10     
+ Partials      184      181       -3
Impacted Files Coverage Δ
app/dashboard/utils.py 34.49% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9bc8a...c480155. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #4238 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4238      +/-   ##
==========================================
- Coverage   30.28%   30.24%   -0.05%     
==========================================
  Files         209      209              
  Lines       16604    16604              
  Branches     2222     2222              
==========================================
- Hits         5029     5022       -7     
- Misses      11391    11401      +10     
+ Partials      184      181       -3
Impacted Files Coverage Δ
app/dashboard/utils.py 34.49% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9bc8a...c480155. Read the comment docs.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the update - I like it 👍

@danlipert danlipert merged commit 61961fe into master Apr 22, 2019
@thelostone-mc thelostone-mc deleted the thelostone-mc-patch-2 branch April 22, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants