Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users invite #4235

Merged
merged 17 commits into from
Apr 30, 2019
Merged

Users invite #4235

merged 17 commits into from
Apr 30, 2019

Conversation

octavioamu
Copy link
Contributor

Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@octavioamu octavioamu requested a review from SaptakS April 19, 2019 03:40
@octavioamu
Copy link
Contributor Author

@SaptakS I had started the directory invite feature take a look into the query to fetch bounties. Also made it in a flexible way to take the logged user or by id if present.

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #4235 into master will decrease coverage by 0.02%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4235      +/-   ##
==========================================
- Coverage   30.28%   30.26%   -0.03%     
==========================================
  Files         209      209              
  Lines       16604    16619      +15     
  Branches     2222     2224       +2     
==========================================
+ Hits         5029     5030       +1     
- Misses      11391    11405      +14     
  Partials      184      184
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
app/dashboard/views.py 13.71% <6.66%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9bc8a...9151930. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #4235 into master will increase coverage by 0.08%.
The diff coverage is 36.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4235      +/-   ##
=========================================
+ Coverage   30.12%   30.2%   +0.08%     
=========================================
  Files         209     209              
  Lines       16738   16768      +30     
  Branches     2239    2242       +3     
=========================================
+ Hits         5042    5065      +23     
- Misses      11515   11516       +1     
- Partials      181     187       +6
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
app/dashboard/models.py 56.57% <100%> (+0.77%) ⬆️
app/dashboard/views.py 14.09% <34.48%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b9b2f7...4a1fd6b. Read the comment docs.

@octavioamu octavioamu marked this pull request as ready for review April 24, 2019 22:01
SaptakS
SaptakS previously approved these changes Apr 29, 2019
@SaptakS SaptakS merged commit 37cf435 into master Apr 30, 2019
@thelostone-mc thelostone-mc deleted the users-invite branch July 4, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants