Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsletter 4/18 #4234

Merged
merged 2 commits into from
Apr 19, 2019
Merged

newsletter 4/18 #4234

merged 2 commits into from
Apr 19, 2019

Conversation

vs77bb
Copy link
Contributor

@vs77bb vs77bb commented Apr 19, 2019

Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@vs77bb vs77bb requested review from owocki and danlipert April 19, 2019 00:13
app/retail/emails.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #4234 into stable will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #4234      +/-   ##
==========================================
+ Coverage   30.27%   30.31%   +0.04%     
==========================================
  Files         209      209              
  Lines       16603    16603              
  Branches     2223     2223              
==========================================
+ Hits         5026     5033       +7     
+ Misses      11397    11387      -10     
- Partials      180      183       +3
Impacted Files Coverage Δ
app/retail/emails.py 21.52% <0%> (ø) ⬆️
app/dashboard/utils.py 36.22% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c80c3...c69280e. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owocki made the comment changes ! getting this in

@thelostone-mc thelostone-mc merged commit ff2d3db into stable Apr 19, 2019
@thelostone-mc thelostone-mc deleted the newsletter041819 branch April 19, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants