Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hackathon: prettify #4230

Merged
merged 5 commits into from
Apr 22, 2019
Merged

hackathon: prettify #4230

merged 5 commits into from
Apr 22, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Apr 18, 2019

Description
  • update the banner to make it a lil easier on the eyes
  • update the title + subheading to match the rest of the site
  • add a bit of animation
  • give more breathing space to the section where bounties are displayed & sidebar search
  • update STATUS -> ORGS in the sidebar search
  • removed unused styles/code
  • link on bounty detail page for a hackathon bounty is updated to point to the hackathon page as opposed to the explorer AS SHOWN HERE

Recording : https://gitcoincore.slack.com/archives/CGR0V2TRV/p1555590611002900

@alexvotofuture
Copy link
Contributor

alexvotofuture commented Apr 18, 2019

Hey @thelostone-mc, thanks for working to make the prize explorer even better!

Some feedback on the changes:

  • Banner should be purple, similar to the Ethereal Summit branding
  • Change "orgs" to "Sponsors"
  • Can we eliminate the "network" filter on the sidebar entirely? We only want the prizes deployed to main net anyway

Great stuff. Will post some additional bug fix issues separately. Thank you!

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Apr 19, 2019

@alexvotofuture

  • Making the banner just purple seemed a lil dull !
    I updated it to the red & purple from Ethereal Summit as per their guide to create a gradient effect as SHOWN HERE. It's on their site + merchandise
    Would that be alright ?
  • updated it to sponsors
  • updated it to hide network on live. (will still be view in dev env to make testing easier)

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #4230 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4230      +/-   ##
==========================================
- Coverage   30.24%   30.24%   -0.01%     
==========================================
  Files         209      209              
  Lines       16604    16606       +2     
  Branches     2222     2223       +1     
==========================================
  Hits         5022     5022              
- Misses      11401    11403       +2     
  Partials      181      181
Impacted Files Coverage Δ
app/dashboard/views.py 13.78% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61961fe...bc60667. Read the comment docs.

@thelostone-mc thelostone-mc added 3 and removed 2 labels Apr 19, 2019
@thelostone-mc thelostone-mc requested a review from SaptakS April 20, 2019 09:06
@SaptakS SaptakS merged commit d867f84 into master Apr 22, 2019
@thelostone-mc thelostone-mc deleted the prettify branch July 4, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants