Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination and order by in hackathon #4206

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Conversation

octavioamu
Copy link
Contributor

Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #4206 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4206      +/-   ##
==========================================
- Coverage   30.37%   30.06%   -0.31%     
==========================================
  Files         206      206              
  Lines       16404    16908     +504     
  Branches     2156     2308     +152     
==========================================
+ Hits         4982     5083     +101     
- Misses      11242    11631     +389     
- Partials      180      194      +14
Impacted Files Coverage Δ
app/app/urls.py 84.74% <0%> (-5.26%) ⬇️
app/kudos/views.py 21.91% <0%> (-0.07%) ⬇️
...itcoinbot/management/commands/get_notifications.py 0% <0%> (ø) ⬆️
app/dashboard/views.py 15.55% <0%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07c199...a502b42. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #4206 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4206   +/-   ##
=======================================
  Coverage   30.37%   30.37%           
=======================================
  Files         206      206           
  Lines       16404    16404           
  Branches     2156     2156           
=======================================
  Hits         4982     4982           
  Misses      11242    11242           
  Partials      180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07c199...dbda705. Read the comment docs.

@danlipert danlipert merged commit 2bdd096 into master Apr 15, 2019
@thelostone-mc thelostone-mc deleted the fix/hackathon-filters branch July 4, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants