-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #4204 - Homepage video preview blocks #4205
Issue #4204 - Homepage video preview blocks #4205
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4205 +/- ##
==========================================
- Coverage 30.37% 30.33% -0.04%
==========================================
Files 206 206
Lines 16404 16404
Branches 2156 2156
==========================================
- Hits 4982 4976 -6
- Misses 11242 11248 +6
Partials 180 180
Continue to review full report at Codecov.
|
@@ -275,7 +264,7 @@ <h2>{% trans "Get to know us better" %}</h2> | |||
</div> | |||
</div> | |||
</div> | |||
<div id="articles"> | |||
<div id="articles" class="articles"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaxStalker hmm could we keep it as an id
?
Unless you see a reason where this would be reused again elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this particular case ids were used for styling - which is "no-no", since it creates more problems in the future. I've left ids there in case there are links elsewhere that reference them.
We can refactor "articles" to "home_articles" (or something similar) if you think this might introduce name collisions later.
@MaxStalker could you address my comments ? Otherwise LGTM |
@thelostone-mc I've updated the code. Can you give it another look? |
thanks @MaxStalker ^^ and yup it looks good ^^ |
Description
Video previews on home page are using SVGs at the moment. Text inside those is not outlined so it renders with a default serif font and is not centered in that block.
Here's how it looks currently:
And here's proposed solution:
Checklist
Affected core subsystem(s)
User interface
Refers/Fixes
This PR fixes #4204
Testing and Sign-off
Tested on local version of site using docker. Checked with different device screen width to ensure responsiveness:
https://www.loom.com/share/594acd535ed242de8d61544eddfac5e9
Contributor
make test
and everything passed!Reviewer
Funder