Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon add sponsor logos #4185

Merged
merged 10 commits into from
Apr 17, 2019
Merged

Hackathon add sponsor logos #4185

merged 10 commits into from
Apr 17, 2019

Conversation

octavioamu
Copy link
Contributor

Description
Checklist
Affected core subsystem(s)
Refers/Fixes

Fixes #4075

Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #4185 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4185   +/-   ##
=======================================
  Coverage   30.37%   30.37%           
=======================================
  Files         206      206           
  Lines       16404    16404           
  Branches     2156     2156           
=======================================
  Hits         4982     4982           
  Misses      11242    11242           
  Partials      180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977ad5d...64c3b17. Read the comment docs.

@octavioamu octavioamu changed the title add logos Hackathon add sponsor logos Apr 11, 2019
@thelostone-mc
Copy link
Member

@octavioamu could we compress the svg ?

@octavioamu
Copy link
Contributor Author

@thelostone-mc ready to merge!!! Can you merge it so we deploy it tomo?

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a few style things

app/dashboard/templates/dashboard/index.html Show resolved Hide resolved
app/dashboard/templates/shared/hackathon_sponsors.html Outdated Show resolved Hide resolved
app/dashboard/templates/shared/hackathon_sponsors.html Outdated Show resolved Hide resolved
app/dashboard/templates/shared/hackathon_sponsors.html Outdated Show resolved Hide resolved
@danlipert danlipert merged commit ae710f9 into master Apr 17, 2019
@thelostone-mc thelostone-mc deleted the hackathon-logos branch July 4, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build - Add Logos to Hackathon Landing Page
4 participants