Hackathon filter #4145

octavioamu · 2019-04-08T19:53:32Z

Description

Checklist

Read and conforms to the contributor guidelines
Read and conforms to the style guidelines
Linter status: 100% pass
Added relevant tests
Tests pass and code coverage has not decreased
Changes don't break existing behavior
Commit message follows commit guidelines
Code documentation
Completed: Code review by core team and any requested changes

Affected core subsystem(s)

Refers/Fixes

Fixes #4117

Testing and Sign-off

Contributor

Read and followed the Contributor Guidelines
Tested all changes locally
Verified existing functionality
Ran make test and everything passed!

Reviewer

Affirm contributor guidelines have been followed and requested changes made
CI tests and linting pass
No conflicts (migrations, files, etc)
Regression tested against staging or local deployment

Funder

Validated requested changes were made to specification
Bounty payout released to the contributor

…athon-filter

codecov · 2019-04-08T19:58:49Z

Codecov Report

Merging #4145 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4145      +/-   ##
==========================================
- Coverage   30.26%   30.11%   -0.15%     
==========================================
  Files         206      206              
  Lines       16367    16511     +144     
  Branches     2154     2201      +47     
==========================================
+ Hits         4953     4973      +20     
- Misses      11238    11358     +120     
- Partials      176      180       +4

Impacted Files	Coverage Δ
app/avatar/utils.py	`13.57% <0%> (+0.14%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59c074...863edde. Read the comment docs.

codecov · 2019-04-08T19:58:50Z

Codecov Report

Merging #4145 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4145   +/-   ##
=======================================
  Coverage   30.26%   30.26%           
=======================================
  Files         206      206           
  Lines       16370    16370           
  Branches     2152     2152           
=======================================
  Hits         4955     4955           
  Misses      11239    11239           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5cbab...1f8669e. Read the comment docs.

…athon-filter

danlipert

just a few issues! looks nice otherwise 👍

danlipert · 2019-04-11T15:44:48Z

app/assets/v2/js/pages/dashboard.js

    }
  } else {
-    uri += '&event_tag=' + document.hackathon;
+    uri += `&event_tag=${document.hackathon}`;


why the backticks here instead of single quotes?

is a string literal
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

ah my bad! thanks!

app/assets/v2/js/pages/dashboard.js

codecov · 2019-04-11T16:39:22Z

Codecov Report

Merging #4145 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4145      +/-   ##
=========================================
- Coverage   30.26%   30.1%   -0.16%     
=========================================
  Files         206     206              
  Lines       16367   17018     +651     
  Branches     2154    2296     +142     
=========================================
+ Hits         4953    5124     +171     
- Misses      11238   11712     +474     
- Partials      176     182       +6

Impacted Files	Coverage Δ
app/retail/views.py	`29.23% <0%> (-0.16%)`	⬇️
app/grants/models.py	`52.32% <0%> (+0.84%)`	⬆️
app/dashboard/views.py	`13.13% <0%> (+0.93%)`	⬆️
app/retail/emails.py	`22.91% <0%> (+1.35%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59c074...7be025c. Read the comment docs.

codecov · 2019-04-11T16:39:47Z

Codecov Report

Merging #4145 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4145      +/-   ##
=========================================
- Coverage   30.26%   30.1%   -0.16%     
=========================================
  Files         206     206              
  Lines       16367   17018     +651     
  Branches     2154    2296     +142     
=========================================
+ Hits         4953    5124     +171     
- Misses      11238   11712     +474     
- Partials      176     182       +6

Impacted Files	Coverage Δ
app/retail/views.py	`29.23% <0%> (-0.16%)`	⬇️
app/grants/models.py	`52.32% <0%> (+0.84%)`	⬆️
app/dashboard/views.py	`13.13% <0%> (+0.93%)`	⬆️
app/retail/emails.py	`22.91% <0%> (+1.35%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59c074...7be025c. Read the comment docs.

codecov · 2019-04-11T16:40:03Z

Codecov Report

Merging #4145 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4145      +/-   ##
=========================================
- Coverage   30.26%   30.1%   -0.16%     
=========================================
  Files         206     206              
  Lines       16367   17018     +651     
  Branches     2154    2296     +142     
=========================================
+ Hits         4953    5124     +171     
- Misses      11238   11712     +474     
- Partials      176     182       +6

Impacted Files	Coverage Δ
app/retail/views.py	`29.23% <0%> (-0.16%)`	⬇️
app/grants/models.py	`52.32% <0%> (+0.84%)`	⬆️
app/dashboard/views.py	`13.13% <0%> (+0.93%)`	⬆️
app/retail/emails.py	`22.91% <0%> (+1.35%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59c074...7be025c. Read the comment docs.

codecov · 2019-04-11T16:53:52Z

Codecov Report

Merging #4145 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4145   +/-   ##
=======================================
  Coverage   30.26%   30.26%           
=======================================
  Files         206      206           
  Lines       16370    16370           
  Branches     2152     2152           
=======================================
  Hits         4955     4955           
  Misses      11239    11239           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5cbab...1f8669e. Read the comment docs.

codecov · 2019-04-11T16:53:53Z

Codecov Report

Merging #4145 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4145   +/-   ##
=======================================
  Coverage   30.26%   30.26%           
=======================================
  Files         206      206           
  Lines       16370    16370           
  Branches     2152     2152           
=======================================
  Hits         4955     4955           
  Misses      11239    11239           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5cbab...1f8669e. Read the comment docs.

codecov · 2019-04-11T16:56:21Z

Codecov Report

Merging #4145 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4145   +/-   ##
=======================================
  Coverage   30.26%   30.26%           
=======================================
  Files         206      206           
  Lines       16370    16370           
  Branches     2152     2152           
=======================================
  Hits         4955     4955           
  Misses      11239    11239           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5cbab...1f8669e. Read the comment docs.

octavioamu added 4 commits April 5, 2019 22:14

add dynamic filters

2ecc185

add dynamic filters

52c0c33

add filters

bf411c1

Merge branch 'hackathon-filter' of github.com:gitcoinco/web into hack…

65178a1

…athon-filter

coderberry added the in progress label Apr 8, 2019

octavioamu requested review from SaptakS and thelostone-mc April 8, 2019 19:54

Merge branch 'master' into hackathon-filter

863edde

octavioamu added 2 commits April 8, 2019 17:04

reset filters

c9ab3d4

Merge branch 'hackathon-filter' of github.com:gitcoinco/web into hack…

ebb1794

…athon-filter

danlipert suggested changes Apr 11, 2019

View reviewed changes

remove comment

7be025c

Merge branch 'master' into hackathon-filter

1f8669e

danlipert approved these changes Apr 11, 2019

View reviewed changes

danlipert merged commit 4be359b into master Apr 11, 2019

thelostone-mc deleted the hackathon-filter branch July 4, 2019 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hackathon filter #4145

Hackathon filter #4145

octavioamu commented Apr 8, 2019

codecov bot commented Apr 8, 2019

codecov bot commented Apr 8, 2019 •

edited

Loading

danlipert left a comment

danlipert Apr 11, 2019

octavioamu Apr 11, 2019 •

edited

Loading

danlipert Apr 11, 2019

codecov bot commented Apr 11, 2019

codecov bot commented Apr 11, 2019

codecov bot commented Apr 11, 2019

codecov bot commented Apr 11, 2019 •

edited

Loading

codecov bot commented Apr 11, 2019

codecov bot commented Apr 11, 2019

Hackathon filter #4145

Hackathon filter #4145

Conversation

octavioamu commented Apr 8, 2019

Description

Checklist

Affected core subsystem(s)

Refers/Fixes

Testing and Sign-off

Contributor

Reviewer

Funder

codecov bot commented Apr 8, 2019

Codecov Report

codecov bot commented Apr 8, 2019 • edited Loading

Codecov Report

danlipert left a comment

Choose a reason for hiding this comment

danlipert Apr 11, 2019

Choose a reason for hiding this comment

octavioamu Apr 11, 2019 • edited Loading

Choose a reason for hiding this comment

danlipert Apr 11, 2019

Choose a reason for hiding this comment

codecov bot commented Apr 11, 2019

Codecov Report

codecov bot commented Apr 11, 2019

Codecov Report

codecov bot commented Apr 11, 2019

Codecov Report

codecov bot commented Apr 11, 2019 • edited Loading

Codecov Report

codecov bot commented Apr 11, 2019

Codecov Report

codecov bot commented Apr 11, 2019

Codecov Report

codecov bot commented Apr 8, 2019 •

edited

Loading

octavioamu Apr 11, 2019 •

edited

Loading

codecov bot commented Apr 11, 2019 •

edited

Loading