Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle non-metamask web3 browsers #4143

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Apr 8, 2019

Description

This PR makes it so that the frontend fails gracefully for non web3 browsers

Refers/Fixes
Testing and Sign-off

Self; I think @ceresstation was asking for help on this back when he was trying to get Aragon support enabled too!

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #4143 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4143      +/-   ##
==========================================
- Coverage   30.26%   30.24%   -0.02%     
==========================================
  Files         206      206              
  Lines       16367    16375       +8     
  Branches     2154     2163       +9     
==========================================
  Hits         4953     4953              
- Misses      11238    11244       +6     
- Partials      176      178       +2
Impacted Files Coverage Δ
app/dashboard/router.py 30.25% <0%> (-0.1%) ⬇️
app/app/urls.py 90% <0%> (ø) ⬆️
app/retail/views.py 29.39% <0%> (ø) ⬆️
app/avatar/utils.py 13.43% <0%> (ø) ⬆️
app/marketing/views.py 12.3% <0%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156dfd3...376df09. Read the comment docs.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelostone-mc
Copy link
Member

Thanks @owocki ! Glad to have you contributing :) ( sorry couldn't resist :P )

@thelostone-mc thelostone-mc merged commit 808072f into master Apr 9, 2019
@thelostone-mc thelostone-mc deleted the kevin/metamask-fixes-2 branch April 9, 2019 10:44
@owocki owocki mentioned this pull request Apr 9, 2019
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants