Suggested Contributor #4137

SaptakS · 2019-04-08T13:34:27Z

Description

Suggested Contributor

Checklist

Read and conforms to the contributor guidelines
Read and conforms to the style guidelines
Linter status: 100% pass
Added relevant tests
Tests pass and code coverage has not decreased
Changes don't break existing behavior
Commit message follows commit guidelines
Code documentation
Completed: Code review by core team and any requested changes

Affected core subsystem(s)

Refers/Fixes

Testing and Sign-off

Contributor

Read and followed the Contributor Guidelines
Tested all changes locally
Verified existing functionality
Ran make test and everything passed!

Reviewer

Affirm contributor guidelines have been followed and requested changes made
CI tests and linting pass
No conflicts (migrations, files, etc)
Regression tested against staging or local deployment

Funder

Validated requested changes were made to specification
Bounty payout released to the contributor

codecov · 2019-04-08T13:39:36Z

Codecov Report

Merging #4137 into master will decrease coverage by <.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #4137      +/-   ##
==========================================
- Coverage   30.26%   30.25%   -0.01%     
==========================================
  Files         206      206              
  Lines       16361    16365       +4     
  Branches     2154     2155       +1     
==========================================
+ Hits         4951     4952       +1     
- Misses      11234    11237       +3     
  Partials      176      176

Impacted Files	Coverage Δ
app/dashboard/views.py	`12.25% <25%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c3a5d...d82ac5f. Read the comment docs.

codecov · 2019-04-08T13:39:36Z

Codecov Report

Merging #4137 into master will decrease coverage by 0.06%.
The diff coverage is 7.5%.

@@            Coverage Diff             @@
##           master    #4137      +/-   ##
==========================================
- Coverage   30.19%   30.13%   -0.07%     
==========================================
  Files         209      209              
  Lines       16655    16692      +37     
  Branches     2224     2230       +6     
==========================================
+ Hits         5029     5030       +1     
- Misses      11445    11481      +36     
  Partials      181      181

Impacted Files	Coverage Δ
app/app/urls.py	`90% <ø> (ø)`	⬆️
app/dashboard/helpers.py	`14.17% <0%> (-0.9%)`	⬇️
app/dashboard/views.py	`13.64% <13.33%> (-0.08%)`	⬇️
app/marketing/mails.py	`11.52% <50%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53fc46b...06b0453. Read the comment docs.

…uggest-contributor

…butor

octavioamu · 2019-04-16T03:55:09Z

app/assets/v2/js/pages/new_bounty.js

@@ -295,7 +384,8 @@ $(document).ready(function() {
        repo_type: data.repo_type,
        featuring_date: data.featuredBounty && ((new Date().getTime() / 1000) | 0) || 0,
        reservedFor: reservedFor ? reservedFor.text : '',
-        tokenName
+        tokenName,
+        invite: inviteContributors


I'm sending an array of usernames ['octavioamu', 'saptak']
I'm suppose you are going to get this data to make the email sending.

octavioamu · 2019-04-16T03:58:06Z

app/dashboard/views.py

+            .order_by('-fulfillment_count')
+
+    keywords_filter = Q()
+    for keyword in keywords:


I had changed this query to work with more than one keyword and also changed the front end to send is as param, since is a GET and there is no body data.

octavioamu

@SaptakS I made some changes so left some explanation in the comments.

…uggest-contributor

danlipert · 2019-04-22T13:54:00Z

app/assets/v2/js/pages/new_bounty.js

+  $.ajax(settings).done(function(response) {
+    let groups = {
+      'contributors': 'Recently worked with you',
+      'recommended_developers': 'Recomended based on skills',


Typo here Recomended -> Recommended

danlipert

Looking pretty good! I loved the demo last week - can we get this finished up for the deploy this week? I know some folks are really excited to get this into production.

danlipert · 2019-04-22T13:54:52Z

app/dashboard/helpers.py

@@ -504,6 +504,41 @@ def create_new_bounty(old_bounties, bounty_payload, bounty_details, bounty_id):
                except Exception as e:
                    logger.error(e)

+            bounty_invitees = metadata.get('invite', '')
+            print (bounty_invitees)


leftover print statement

danlipert · 2019-04-22T13:55:14Z

app/dashboard/helpers.py

+                    bounty_invite.inviter.add(inviter.user)
+                    bounty_invite.invitee.add(profile.user)
+                    emails.append(profile.email)
+                print(emails)


leftover prints here

danlipert · 2019-04-22T13:56:55Z

app/dashboard/helpers.py

+                emails = []
+                inviter = Profile.objects.get(handle=new_bounty.bounty_owner_github_username)
+                invite_url = get_bounty_invite_url(inviter, new_bounty.id)
+                msg = "Check out this bounty that pays out" + \


Are we happy with this copy here? @PixelantDesign @frankchen07 - I think the formatting here needs a space between the word out and the bounty value.

app/dashboard/helpers.py

SaptakS · 2019-04-23T21:24:28Z

@danlipert addressed your concerns. Please review.

danlipert · 2019-04-24T13:33:50Z

app/assets/v2/js/pages/new_bounty.js

@@ -38,6 +38,94 @@ function doShowQuickstart(url) {
  return true;
 }

+var procesedData;


typo: procesedData should be processedData

…uggest-contributor

Adds logic to send 3 top contributors I haver worked with

d82ac5f

SaptakS added the in progress label Apr 8, 2019

SaptakS and others added 13 commits April 8, 2019 23:23

Merge branch 'master' into suggest-contributor

4d49c7f

Merge branch 'master' into suggest-contributor

f28de68

Adds URl for suggested contributor fetching

965ee01

Add frontend to show user icons

68e9164

Merge branch 'suggest-contributor' of github.com:gitcoinco/web into s…

3861aa0

…uggest-contributor

Fetch data on clicking select

8258d38

add select groups

04a8a44

Merge branch 'master' of github.com:gitcoinco/web into suggest-contri…

3c93308

…butor

search by multiple skills

1a93525

fix behavior

553fcdd

fix isort

fc40dda

add data to request

9175630

remove comments

874b6a3

octavioamu reviewed Apr 16, 2019

View reviewed changes

remove comments

696b405

octavioamu reviewed Apr 16, 2019

View reviewed changes

octavioamu and others added 5 commits April 16, 2019 01:00

Merge branch 'master' into suggest-contributor

0c4c44d

remove when no data

50f9879

Merge branch 'suggest-contributor' of github.com:gitcoinco/web into s…

e8ce1d1

…uggest-contributor

Merge branch 'suggest-contributor' of github.com:gitcoinco/web into s…

2eb01da

…uggest-contributor

Fix conflicts

005e93b

SaptakS changed the title ~~[WIP] Suggested Contributor~~ Suggested Contributor Apr 16, 2019

SaptakS and others added 3 commits April 17, 2019 02:12

Send ids for the contributors

26629be

invites now array of users id

f09ec45

Merge branch 'master' into suggest-contributor

02cdb32

octavioamu previously approved these changes Apr 17, 2019

View reviewed changes

SaptakS added 3 commits April 17, 2019 18:13

Adds function to send out emails

be24d54

Merge branch 'suggest-contributor' of github.com:gitcoinco/web into s…

1de1bd6

…uggest-contributor

Fix keys

da7b745

SaptakS dismissed octavioamu’s stale review via da7b745 April 17, 2019 12:52

SaptakS added 5 commits April 17, 2019 18:51

Adds check condition to not show kudos

60334ee

Fix underscore error

4dd0a16

Fix the concat issue

26daf22

Adds bountyinvites model import

7782f86

Fix the email logic

ceed39c

octavioamu requested review from danlipert and thelostone-mc April 17, 2019 19:31

danlipert reviewed Apr 22, 2019

View reviewed changes

danlipert suggested changes Apr 22, 2019

View reviewed changes

SaptakS added 2 commits April 24, 2019 02:51

Fixes suggested by dan

e96bce3

Merge branch 'master' into suggest-contributor

3c15ff1

thelostone-mc requested a review from danlipert April 24, 2019 13:29

danlipert previously approved these changes Apr 24, 2019

View reviewed changes

SaptakS added 2 commits April 24, 2019 19:08

Fixes typo

0af2154

Merge branch 'suggest-contributor' of github.com:gitcoinco/web into s…

e420edb

…uggest-contributor

SaptakS dismissed danlipert’s stale review via e420edb April 24, 2019 13:41

SaptakS and others added 2 commits April 24, 2019 19:12

Fix some more typo

a78bd02

Merge branch 'master' into suggest-contributor

06b0453

danlipert approved these changes Apr 24, 2019

View reviewed changes

danlipert merged commit f700ddb into master Apr 24, 2019

thelostone-mc deleted the suggest-contributor branch July 4, 2019 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggested Contributor #4137

Suggested Contributor #4137

SaptakS commented Apr 8, 2019

codecov bot commented Apr 8, 2019

codecov bot commented Apr 8, 2019 •

edited

Loading

octavioamu Apr 16, 2019

octavioamu Apr 16, 2019

octavioamu left a comment

danlipert Apr 22, 2019

danlipert left a comment

danlipert Apr 22, 2019

danlipert Apr 22, 2019

danlipert Apr 22, 2019

SaptakS commented Apr 23, 2019

danlipert Apr 24, 2019

Suggested Contributor #4137

Suggested Contributor #4137

Conversation

SaptakS commented Apr 8, 2019

Description

Checklist

Affected core subsystem(s)

Refers/Fixes

Testing and Sign-off

Contributor

Reviewer

Funder

codecov bot commented Apr 8, 2019

Codecov Report

codecov bot commented Apr 8, 2019 • edited Loading

Codecov Report

octavioamu Apr 16, 2019

Choose a reason for hiding this comment

octavioamu Apr 16, 2019

Choose a reason for hiding this comment

octavioamu left a comment

Choose a reason for hiding this comment

danlipert Apr 22, 2019

Choose a reason for hiding this comment

danlipert left a comment

Choose a reason for hiding this comment

danlipert Apr 22, 2019

Choose a reason for hiding this comment

danlipert Apr 22, 2019

Choose a reason for hiding this comment

danlipert Apr 22, 2019

Choose a reason for hiding this comment

SaptakS commented Apr 23, 2019

danlipert Apr 24, 2019

Choose a reason for hiding this comment

codecov bot commented Apr 8, 2019 •

edited

Loading