Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if latest_comment_url is valid when processing gh notifications #4136

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

danlipert
Copy link
Contributor

@danlipert danlipert commented Apr 8, 2019

Description

Prevents sentry alert when github notifications do not have a valid latest_comment_url

Checklist
Affected core subsystem(s)

gitcoinbot

Testing and Sign-off

the split call on latest_comment_url usually throws an unhandled exception, so this change prevents that by continuing to loop over the notifications before getting to the split call

Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #4136 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4136      +/-   ##
==========================================
- Coverage   30.37%   30.37%   -0.01%     
==========================================
  Files         206      206              
  Lines       16401    16404       +3     
  Branches     2155     2156       +1     
==========================================
  Hits         4982     4982              
- Misses      11239    11242       +3     
  Partials      180      180
Impacted Files Coverage Δ
...itcoinbot/management/commands/get_notifications.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c059a82...2e8568e. Read the comment docs.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octavioamu octavioamu merged commit dc2c030 into master Apr 12, 2019
@thelostone-mc thelostone-mc deleted the comment-split branch July 4, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants