Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the bounty acceptance email in admin #4127

Merged
merged 3 commits into from
Apr 5, 2019

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented Apr 5, 2019

Description

The bounty acceptance email in admin was throwing error because there was no default value for rating_count provided in the function.

Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #4127 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4127   +/-   ##
=======================================
  Coverage   30.26%   30.26%           
=======================================
  Files         206      206           
  Lines       16360    16360           
  Branches     2154     2154           
=======================================
  Hits         4951     4951           
  Misses      11233    11233           
  Partials      176      176
Impacted Files Coverage Δ
app/retail/emails.py 21.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74dd8b1...4f62aa0. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #4127 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4127   +/-   ##
=======================================
  Coverage   30.26%   30.26%           
=======================================
  Files         206      206           
  Lines       16360    16360           
  Branches     2154     2154           
=======================================
  Hits         4951     4951           
  Misses      11233    11233           
  Partials      176      176
Impacted Files Coverage Δ
app/retail/emails.py 21.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74dd8b1...4f62aa0. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 55ec29f into gitcoinco:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants