Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grant Funder tweet modal #4113

Merged
merged 3 commits into from
Apr 8, 2019
Merged

Conversation

emiwatanabe422
Copy link
Contributor

@emiwatanabe422 emiwatanabe422 commented Apr 4, 2019

Description

Adds a modal to make it easy to send tweet when a grant is funded.

Checklist
Affected core subsystem(s)
Refers/Fixes

#4091

Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@emiwatanabe422
Copy link
Contributor Author

tweet_modal

thelostone-mc
thelostone-mc previously approved these changes Apr 4, 2019
@thelostone-mc thelostone-mc requested a review from SaptakS April 4, 2019 12:27
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #4113 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4113   +/-   ##
=======================================
  Coverage   30.26%   30.26%           
=======================================
  Files         206      206           
  Lines       16361    16361           
  Branches     2154     2154           
=======================================
  Hits         4951     4951           
  Misses      11234    11234           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb6d9f6...3cc5a43. Read the comment docs.

@SaptakS
Copy link
Contributor

SaptakS commented Apr 4, 2019

@emiwatanabe422 can you fix travis errors. It is just a linting issue to change double quote into single quote and then it should be good to go.

@owocki
Copy link
Contributor

owocki commented Apr 4, 2019

this looks good! cc @PixelantDesign for feedback from a product pespective

@SaptakS SaptakS merged commit 67c3a5d into gitcoinco:master Apr 8, 2019
@emiwatanabe422 emiwatanabe422 deleted the funder-tweet branch April 9, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants