Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating modal #4092

Merged
merged 11 commits into from
Apr 4, 2019
Merged

Rating modal #4092

merged 11 commits into from
Apr 4, 2019

Conversation

octavioamu
Copy link
Contributor

Description
Checklist
Affected core subsystem(s)
Refers/Fixes

Refs : #4018

Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #4092 into master will decrease coverage by <.01%.
The diff coverage is 15.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4092      +/-   ##
==========================================
- Coverage   30.26%   30.26%   -0.01%     
==========================================
  Files         206      206              
  Lines       16345    16360      +15     
  Branches     2155     2154       -1     
==========================================
+ Hits         4947     4951       +4     
- Misses      11222    11233      +11     
  Partials      176      176
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
app/marketing/mails.py 12.92% <0%> (-0.08%) ⬇️
app/dashboard/models.py 54.07% <0%> (ø) ⬆️
app/retail/emails.py 21.56% <100%> (ø) ⬆️
app/dashboard/views.py 12.2% <18.75%> (+0.2%) ⬆️
app/dashboard/utils.py 34.66% <20%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d6764...5adbbe5. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #4092 into master will decrease coverage by 0.01%.
The diff coverage is 20.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4092      +/-   ##
==========================================
- Coverage   30.28%   30.27%   -0.02%     
==========================================
  Files         206      206              
  Lines       16310    16349      +39     
  Branches     2145     2152       +7     
==========================================
+ Hits         4940     4949       +9     
- Misses      11194    11224      +30     
  Partials      176      176
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
app/dashboard/views.py 12.12% <10.25%> (-0.02%) ⬇️
app/dashboard/models.py 54.35% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0226fa3...8885016. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 51d0ae6 into master Apr 4, 2019
@@ -1,6 +1,9 @@
🌈 Funds Paid! 🌈

Your funded issue has been accepted, and the fulfillment transaction is now on the Etherum network!
{% if unrated_count > 0 %}
Rate!!!!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants