Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

designs corrected #4086

Merged
merged 1 commit into from
Apr 1, 2019
Merged

designs corrected #4086

merged 1 commit into from
Apr 1, 2019

Conversation

mehul0698
Copy link
Contributor

@mehul0698 mehul0698 commented Apr 1, 2019

Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@mehul0698
Copy link
Contributor Author

Mistakes:-
image
image
image
image
Corrected:-
!
image
image
image
image
image
image
image

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #4086 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4086      +/-   ##
==========================================
- Coverage   30.28%   30.25%   -0.04%     
==========================================
  Files         206      206              
  Lines       16310    16310              
  Branches     2145     2145              
==========================================
- Hits         4940     4934       -6     
- Misses      11194    11200       +6     
  Partials      176      176
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa7f37...8d72b7d. Read the comment docs.

@mehul0698
Copy link
Contributor Author

mehul0698 commented Apr 1, 2019

@owocki @thelostone-mc I have corrected 7 assets out of which the clothing one and the 2 necklaces I had to make them from scratch. Please review this pr.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for fixing those up mate ^_^

@thelostone-mc thelostone-mc merged commit 0226fa3 into gitcoinco:master Apr 1, 2019
@mehul0698
Copy link
Contributor Author

@owocki you owe me 70 to 75 dollars as 4 I resized and change the artboard and 3 made from scratch.

@owocki
Copy link
Contributor

owocki commented Apr 1, 2019

what are those prices based upon? i'd really like to treat this as a conversation instead of feelling like those prices are demanded

@mehul0698
Copy link
Contributor Author

5 dollars for each resize and 25 for the clothing as made it from scratch and 10 for the necklace as made that from scratch also. Last time I corrected 6 accessories you paid me the same rates otherwise what ever is fine with you.

@owocki
Copy link
Contributor

owocki commented Apr 1, 2019

OK cool -- FYI for go-forward; i closed down the avatar asset bounty for the time being (i want to open another one soon though)

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.50000 ETH (70.6 USD @ $141.2/ETH) has been granted to @mehul0698 for this issue from @owocki. ⚡️

Nice work @mehul0698! Your tip has automatically been deposited in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants