Adds average star rating calculations #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4080 +/- ##
==========================================
- Coverage 30.28% 30.22% -0.06%
==========================================
Files 206 206
Lines 16334 16345 +11
Branches 2149 2155 +6
==========================================
- Hits 4946 4941 -5
- Misses 11212 11228 +16
Partials 176 176
Continue to review full report at Codecov.
|
danlipert
previously approved these changes
Apr 2, 2019
app/dashboard/models.py
Outdated
| feedbacks = FeedbackEntry.objects.filter(receiver_profile=self).all() | ||
| average_rating = {} | ||
| average_rating['overall'] = sum([feedback.rating for feedback in feedbacks]) / feedbacks.count() | ||
| # average_rating['code_quality_rating'] = sum([feedback.code_quality_rating for feedback in feedbacks]) / feedbacks.count() |
There was a problem hiding this comment.
I assume these commented out lines are for upcoming features, right?
There was a problem hiding this comment.
Nevermind - I see they are in Octavio's PR 👍
There was a problem hiding this comment.
Since that PR is merged now, I will remove the comments now. :)
thelostone-mc
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calculates the average star rating for a profile and returns a dictionary of different ratings.
Since the star rating PR hasn't been merged, I have commented out the calculation of the individual quality ratings so that once that gets merged, I can uncomment that.
Checklist
Affected core subsystem(s)
Refers/Fixes
Fixes #4059