Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cypress framework and visit tests #4078

Merged
merged 5 commits into from
Apr 4, 2019
Merged

add cypress framework and visit tests #4078

merged 5 commits into from
Apr 4, 2019

Conversation

danlipert
Copy link
Contributor

Description

This PR adds the cypress integration test suite and a simple series of "visit tests.

Checklist
Affected core subsystem(s)

Testing

Refers/Fixes

Refs: #4028

Testing and Sign-off

This PR just adds additional tests and doesn't alter the app

Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #4078 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4078   +/-   ##
=======================================
  Coverage   30.26%   30.26%           
=======================================
  Files         206      206           
  Lines       16345    16345           
  Branches     2155     2155           
=======================================
  Hits         4947     4947           
  Misses      11222    11222           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f758c04...85ede96. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #4078 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4078   +/-   ##
=======================================
  Coverage   30.22%   30.22%           
=======================================
  Files         205      205           
  Lines       16236    16236           
  Branches     2136     2136           
=======================================
  Hits         4908     4908           
  Misses      11154    11154           
  Partials      174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a609fee...eabd61e. Read the comment docs.

@octavioamu
Copy link
Contributor

oh my hero!!

@SaptakS
Copy link
Contributor

SaptakS commented Apr 1, 2019

@danlipert this is great!!! How do we run the tests though? Maybe add that command into the Makefile ?

@danlipert
Copy link
Contributor Author

@SaptakS right now I just use npx cypress open which opens the interactive UI (and a new chrome instance to run the tests) - but yeah I should probably add some instructions

@SaptakS SaptakS merged commit 57a5c79 into master Apr 4, 2019
@thelostone-mc thelostone-mc deleted the cypress-setup branch July 4, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants