Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required field in admin #4058

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Fix required field in admin #4058

merged 1 commit into from
Mar 28, 2019

Conversation

octavioamu
Copy link
Contributor

Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #4058 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4058   +/-   ##
=======================================
  Coverage   30.23%   30.23%           
=======================================
  Files         205      205           
  Lines       16234    16234           
  Branches     2135     2135           
=======================================
  Hits         4908     4908           
  Misses      11152    11152           
  Partials      174      174
Impacted Files Coverage Δ
app/dashboard/models.py 54.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317576e...cd74ef5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #4058 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4058   +/-   ##
=======================================
  Coverage   30.23%   30.23%           
=======================================
  Files         205      205           
  Lines       16234    16234           
  Branches     2135     2135           
=======================================
  Hits         4908     4908           
  Misses      11152    11152           
  Partials      174      174
Impacted Files Coverage Δ
app/dashboard/models.py 54.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317576e...cd74ef5. Read the comment docs.

@SaptakS SaptakS merged commit 3eca6f9 into master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants