#3913 Correct validation in JS

[rafalkowalski]

Description

Merge requests covers all bugs pointed at #3913 (comment)

I've fixed validation when you pass invalid data.

Checklist

• Read and conforms to the contributor guidelines
• Read and conforms to the style guidelines
• Linter status: 100% pass
• Added relevant tests
• Tests pass and code coverage has not decreased
• Changes don't break existing behavior
• Commit message follows commit guidelines
• Code documentation
• Completed: Code review by core team and any requested changes

Affected core subsystem(s)

Refers/Fixes

Testing and Sign-off

Contributor

• Read and followed the Contributor Guidelines
• Tested all changes locally
• Verified existing functionality
• Ran make test and everything passed!

Reviewer

• Affirm contributor guidelines have been followed and requested changes made
• CI tests and linting pass
• No conflicts (migrations, files, etc)
• Regression tested against staging or local deployment

Funder

• Validated requested changes were made to specification
• Bounty payout released to the contributor

[codecov]

Codecov Report

Merging #4054 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4054   +/-   ##
=======================================
  Coverage   30.22%   30.22%           
=======================================
  Files         205      205           
  Lines       16240    16240           
  Branches     2139     2138    -1     
=======================================
  Hits         4908     4908           
  Misses      11158    11158           
  Partials      174      174

Impacted Files	Coverage Δ
app/grants/views.py	14.8% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080aa61...c103286. Read the comment docs.

[owocki]

the 'testing and sign off' part of the PR desc is empty. @rafalkowalski how did you test?

also i dont see the buttons re-enabled on /grants on this branch. we will need to do that so that this feature can be used.

[rafalkowalski]

@owocki I've tested it locally in docker image.

I'm not sure if re-enable button but was specified in #3913

[owocki]

i dont understand what your second comment means.

how did you test if you didnt re-enable the UI button?