Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require login for invite code URL #4043

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented Mar 26, 2019

Description

Related to https://sentry.io/organizations/gitcoin/issues/938282538/?project=1398424

Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #4043 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4043      +/-   ##
==========================================
+ Coverage   30.13%   30.13%   +<.01%     
==========================================
  Files         205      205              
  Lines       16042    16043       +1     
  Branches     2118     2118              
==========================================
+ Hits         4834     4835       +1     
  Misses      11034    11034              
  Partials      174      174
Impacted Files Coverage Δ
app/dashboard/views.py 12.01% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1240aa...c45c762. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #4043 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4043      +/-   ##
==========================================
+ Coverage   30.13%   30.13%   +<.01%     
==========================================
  Files         205      205              
  Lines       16042    16043       +1     
  Branches     2118     2118              
==========================================
+ Hits         4834     4835       +1     
  Misses      11034    11034              
  Partials      174      174
Impacted Files Coverage Δ
app/dashboard/views.py 12.01% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1240aa...c45c762. Read the comment docs.

@thelostone-mc thelostone-mc merged commit d2612c0 into gitcoinco:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants