Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infura changes #4017

Merged
merged 5 commits into from
Mar 21, 2019
Merged

Infura changes #4017

merged 5 commits into from
Mar 21, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Mar 20, 2019

Description
Checklist
Affected core subsystem(s)
Refers/Fixes

Refs: #3370 #4020

Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #4017 into master will decrease coverage by 12.85%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4017       +/-   ##
===========================================
- Coverage   30.03%   17.17%   -12.86%     
===========================================
  Files         205      194       -11     
  Lines       15996    15926       -70     
  Branches     2111     2109        -2     
===========================================
- Hits         4804     2735     -2069     
- Misses      11020    13181     +2161     
+ Partials      172       10      -162
Impacted Files Coverage Δ
app/dashboard/utils.py 16.91% <0%> (-18.29%) ⬇️
app/app/settings.py 78.68% <100%> (+0.16%) ⬆️
app/kudos/forms.py 0% <0%> (-100%) ⬇️
app/grants/serializers.py 0% <0%> (-100%) ⬇️
app/avatar/serializers.py 0% <0%> (-100%) ⬇️
app/grants/urls.py 0% <0%> (-100%) ⬇️
app/inbox/urls.py 0% <0%> (-100%) ⬇️
app/avatar/urls.py 0% <0%> (-100%) ⬇️
app/grants/forms.py 0% <0%> (-100%) ⬇️
app/avatar/router.py 0% <0%> (-90.91%) ⬇️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b7f8e...23e672e. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #4017 into master will increase coverage by <.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4017      +/-   ##
==========================================
+ Coverage   30.07%   30.07%   +<.01%     
==========================================
  Files         205      205              
  Lines       16000    16006       +6     
  Branches     2109     2111       +2     
==========================================
+ Hits         4812     4814       +2     
- Misses      11017    11020       +3     
- Partials      171      172       +1
Impacted Files Coverage Δ
app/app/settings.py 78.24% <100%> (+0.16%) ⬆️
app/dashboard/utils.py 34.84% <16.66%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc6466...c52e6d0. Read the comment docs.

danlipert
danlipert previously approved these changes Mar 21, 2019
@danlipert danlipert merged commit 9c87441 into master Mar 21, 2019
@thelostone-mc thelostone-mc deleted the infura-changes branch March 27, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants