Users list #4011

octavioamu · 2019-03-20T03:52:08Z

Description

Checklist

Read and conforms to the contributor guidelines
Read and conforms to the style guidelines
Linter status: 100% pass
Added relevant tests
Tests pass and code coverage has not decreased
Changes don't break existing behavior
Commit message follows commit guidelines
Code documentation
Completed: Code review by core team and any requested changes

Affected core subsystem(s)

Refers/Fixes

Refs: #4019

Testing and Sign-off

Contributor

Read and followed the Contributor Guidelines
Tested all changes locally
Verified existing functionality
Ran make test and everything passed!

Reviewer

Affirm contributor guidelines have been followed and requested changes made
CI tests and linting pass
No conflicts (migrations, files, etc)
Regression tested against staging or local deployment

Funder

Validated requested changes were made to specification
Bounty payout released to the contributor

codecov · 2019-03-20T03:56:27Z

Codecov Report

Merging #4011 into master will decrease coverage by <.01%.
The diff coverage is 14.28%.

@@            Coverage Diff            @@
##           master   #4011      +/-   ##
=========================================
- Coverage   30.01%     30%   -0.01%     
=========================================
  Files         205     205              
  Lines       16000   16007       +7     
  Branches     2111    2111              
=========================================
+ Hits         4802    4803       +1     
- Misses      11026   11032       +6     
  Partials      172     172

Impacted Files	Coverage Δ
app/app/urls.py	`90% <ø> (ø)`	⬆️
app/dashboard/views.py	`11.94% <14.28%> (+0.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83f930...dd1c620. Read the comment docs.

codecov · 2019-03-20T03:56:28Z

Codecov Report

Merging #4011 into master will increase coverage by 0.1%.
The diff coverage is 77.77%.

@@            Coverage Diff            @@
##           master    #4011     +/-   ##
=========================================
+ Coverage   30.26%   30.37%   +0.1%     
=========================================
  Files         206      206             
  Lines       16370    16397     +27     
  Branches     2152     2154      +2     
=========================================
+ Hits         4955     4981     +26     
+ Misses      11239    11236      -3     
- Partials      176      180      +4

Impacted Files	Coverage Δ
app/app/urls.py	`90% <ø> (ø)`	⬆️
app/dashboard/views.py	`13.8% <77.77%> (+1.55%)`	⬆️
app/dashboard/models.py	`54.19% <0%> (+0.12%)`	⬆️
app/economy/models.py	`61% <0%> (+3%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be359b...7c9bae3. Read the comment docs.

owocki · 2019-04-10T20:24:49Z

hey @PixelantDesign @danlipert i spoke with @octavioamu this morning. we were thinking about releasing this this week so it can be used in the ethereal hackathon ( what exists now => http://bits.owocki.com/1cba8654c7ba/Image%202019-04-10%20at%202.23.46%20PM.png is basic search )

then we will build in the fuller features #4019 from there

i think we

dont list this anywhere and just use it internally
slap a 'beta' tag on it
make it so you can only use it if logged in and you're an admin
make the PR in a non-draft state

how does that sound?

PixelantDesign · 2019-04-10T20:27:03Z

Works for me if it's in a good enough state. Though, I have not tested.

danlipert

Almost there 👍

danlipert · 2019-04-11T15:52:31Z

app/dashboard/templates/dashboard/users.html

+          </button>
+
+          <div class="collapse navbar-collapse" id="usersFilters">
+            <!-- <div class="navbar-nav mr-4">


Whats up with this fat comment? :)

is for the next version

danlipert · 2019-04-11T15:53:06Z

app/dashboard/tests/test_users_list.py

+                                       username="user{}".format(i))
+            profile = Profile.objects.create(user=user, data={}, handle="{}".format(i))
+
+    def test_user_list(self):


danlipert · 2019-04-11T15:53:19Z

app/dashboard/views.py

+    context = {}
+    user_list = Profile.objects.all().order_by(order_by).filter(handle__icontains=q).cache()
+
+    # all_notifs = Notification.objects.filter(to_user_id=request.user.id).order_by('-id')


leftover comment

danlipert · 2019-04-11T15:54:14Z

app/dashboard/views.py

+@require_GET
+def users_fetch(request):
+    """Handle displaying users."""
+    q = request.GET.get('search','')


add a space before the final string here like q = request.GET.get('search', '')

danlipert · 2019-04-11T15:54:47Z

app/dashboard/views.py

+    all_pages = Paginator(user_list, limit)
+    all_users = []
+    for user in all_pages.page(page):
+        print(user)


leftover debugging print?

danlipert · 2019-04-11T15:56:00Z

app/dashboard/views.py

+        profile_json = {}
+        profile_json = user.to_standard_dict()
+        if user.avatar_baseavatar_related.exists():
+            profile_json['avatar_id'] = user.avatar_baseavatar_related.first().pk


Better here to assign a var to user.avatar_baseavatar_related.first() and then access the .pk and .avatar_url from that var. Calling .first() multiple times re-queries the database

octavioamu added 2 commits March 19, 2019 23:16

fetch users

20a4793

add data

dd1c620

coderberry added the in progress label Mar 20, 2019

octavioamu and others added 10 commits March 20, 2019 01:24

add keywords

b0d47a9

change to rest

1d637fb

backend

90c8b2a

fix jsonresponse data and add test

5f43187

merge dans code

2517250

fix be results

6678ec6

move to vue to handle data

c5db4b0

add infinite pagination + usersearch

1dccf15

comment not active filters

16950a3

add verify

f274021

octavioamu added priority: medium and removed priority: medium labels Apr 9, 2019

octavioamu self-assigned this Apr 9, 2019

make verification work

ed22557

owocki requested review from danlipert, thelostone-mc and owocki and removed request for danlipert April 10, 2019 20:23

octavioamu added 5 commits April 10, 2019 17:53

add verified badge

2211791

fetch users

0cea1d4

add data

21a0d1f

add keywords

cf58dbb

change to rest

8c4f877

octavioamu and others added 12 commits April 11, 2019 11:40

backend

bf56fd8

fix jsonresponse data and add test

9c8f345

fix be results

aef15a7

move to vue to handle data

23b2abe

add infinite pagination + usersearch

082942d

comment not active filters

752ffc8

add verify

a6414a7

make verification work

7017636

add verified badge

5ff6d7f

clean

2dc8aca

clean code

080a229

Merge branch 'users-list' of github.com:gitcoinco/web into users-list

f380e1b

octavioamu marked this pull request as ready for review April 11, 2019 15:00

Merge branch 'master' into users-list

7b53c57

danlipert suggested changes Apr 11, 2019

View reviewed changes

octavioamu and others added 3 commits April 11, 2019 13:28

review comments

e2b1a45

Merge branch 'master' into users-list

cfec57c

Merge branch 'master' into users-list

7c9bae3

danlipert approved these changes Apr 11, 2019

View reviewed changes

danlipert merged commit aa29b71 into master Apr 11, 2019

coderberry removed the in progress label Apr 11, 2019

thelostone-mc deleted the users-list branch July 4, 2019 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Users list #4011

Users list #4011

octavioamu commented Mar 20, 2019 •

edited

Loading

codecov bot commented Mar 20, 2019

codecov bot commented Mar 20, 2019 •

edited

Loading

owocki commented Apr 10, 2019

PixelantDesign commented Apr 10, 2019

danlipert left a comment

danlipert Apr 11, 2019

octavioamu Apr 11, 2019

danlipert Apr 11, 2019

danlipert Apr 11, 2019

danlipert Apr 11, 2019

danlipert Apr 11, 2019

danlipert Apr 11, 2019

Users list #4011

Users list #4011

Conversation

octavioamu commented Mar 20, 2019 • edited Loading

Description

Checklist

Affected core subsystem(s)

Refers/Fixes

Testing and Sign-off

Contributor

Reviewer

Funder

codecov bot commented Mar 20, 2019

Codecov Report

codecov bot commented Mar 20, 2019 • edited Loading

Codecov Report

owocki commented Apr 10, 2019

PixelantDesign commented Apr 10, 2019

danlipert left a comment

Choose a reason for hiding this comment

danlipert Apr 11, 2019

Choose a reason for hiding this comment

octavioamu Apr 11, 2019

Choose a reason for hiding this comment

danlipert Apr 11, 2019

Choose a reason for hiding this comment

danlipert Apr 11, 2019

Choose a reason for hiding this comment

danlipert Apr 11, 2019

Choose a reason for hiding this comment

danlipert Apr 11, 2019

Choose a reason for hiding this comment

danlipert Apr 11, 2019

Choose a reason for hiding this comment

octavioamu commented Mar 20, 2019 •

edited

Loading

codecov bot commented Mar 20, 2019 •

edited

Loading