Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 men and 3 girly hairstyles #4005

Closed
wants to merge 1 commit into from
Closed

Added 2 men and 3 girly hairstyles #4005

wants to merge 1 commit into from

Conversation

vikrant1697
Copy link
Contributor

@vikrant1697 vikrant1697 commented Mar 19, 2019

Description

This is the same pull request as #3953. Since that pull request had some errors I made another one resolving all of it.

Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@vikrant1697 vikrant1697 mentioned this pull request Mar 19, 2019
19 tasks
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #4005 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4005      +/-   ##
==========================================
- Coverage   30.01%   29.97%   -0.04%     
==========================================
  Files         205      205              
  Lines       16000    16000              
  Branches     2111     2111              
==========================================
- Hits         4802     4796       -6     
- Misses      11026    11032       +6     
  Partials      172      172
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83f930...c0536e2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #4005 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4005      +/-   ##
==========================================
- Coverage   30.01%   29.97%   -0.04%     
==========================================
  Files         205      205              
  Lines       16000    16000              
  Branches     2111     2111              
==========================================
- Hits         4802     4796       -6     
- Misses      11026    11032       +6     
  Partials      172      172
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83f930...c0536e2. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like they've been wired into the avatar

Could you throw recording of using the svgs in the avatar builder and updating your avatar in your instance

@vikrant1697
Copy link
Contributor Author

vikrant1697 commented Mar 25, 2019

@thelostone-mc since it all got a little messy an I had to delete the forked repo I have made another PR #4037. I hope making so many pull requests won't be problem. Won't repeat it again. Please take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants