Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for conversion rate on bounty email is wrong #4003

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Fix for conversion rate on bounty email is wrong #4003

merged 2 commits into from
Mar 19, 2019

Conversation

antonyip
Copy link
Contributor

Description

This PR fixes the conversion issue that is found in #3999

Checklist
Affected core subsystem(s)

N/A

Refers/Fixes

Fixes: #3999

Testing and Sign-off

Small Change Done.

Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #4003 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4003      +/-   ##
==========================================
- Coverage   30.01%   29.97%   -0.04%     
==========================================
  Files         205      205              
  Lines       16000    16000              
  Branches     2111     2111              
==========================================
- Hits         4802     4796       -6     
- Misses      11026    11032       +6     
  Partials      172      172
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8662ba...2be3828. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #4003 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4003      +/-   ##
==========================================
- Coverage   30.01%   29.97%   -0.04%     
==========================================
  Files         205      205              
  Lines       16000    16000              
  Branches     2111     2111              
==========================================
- Hits         4802     4796       -6     
- Misses      11026    11032       +6     
  Partials      172      172
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8662ba...81f154b. Read the comment docs.

@owocki owocki merged commit d83f930 into gitcoinco:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug - conversion rate on bounty email is wrong
2 participants