-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hacklanding fixes #3995
Hacklanding fixes #3995
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3995 +/- ##
=======================================
Coverage 30.01% 30.01%
=======================================
Files 205 205
Lines 15998 15998
Branches 2111 2111
=======================================
Hits 4802 4802
Misses 11024 11024
Partials 172 172 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3995 +/- ##
=======================================
Coverage 30.01% 30.01%
=======================================
Files 205 205
Lines 15998 15998
Branches 2111 2111
=======================================
Hits 4802 4802
Misses 11024 11024
Partials 172 172
Continue to review full report at Codecov.
|
h2, | ||
h3, | ||
h4 { | ||
font-family: Arial-Black, Helvetica, sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new font-family ? I thought we were using Muli throughout the site :P
we can just add g-font-muli
class to the body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in this design, is something separated, also without the top navbar and footer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! Left a few minor comments
Description
Can check the result here https://octavio.stage.gitcoin.co/hackathon/ethhack2019
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
make test
and everything passed!Reviewer
Funder