Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacklanding fixes #3995

Merged
merged 10 commits into from
Mar 19, 2019
Merged

Hacklanding fixes #3995

merged 10 commits into from
Mar 19, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Mar 18, 2019

Description

Can check the result here https://octavio.stage.gitcoin.co/hackathon/ethhack2019

Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #3995 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3995   +/-   ##
=======================================
  Coverage   30.01%   30.01%           
=======================================
  Files         205      205           
  Lines       15998    15998           
  Branches     2111     2111           
=======================================
  Hits         4802     4802           
  Misses      11024    11024           
  Partials      172      172

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b0799...2efe688. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #3995 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3995   +/-   ##
=======================================
  Coverage   30.01%   30.01%           
=======================================
  Files         205      205           
  Lines       15998    15998           
  Branches     2111     2111           
=======================================
  Hits         4802     4802           
  Misses      11024    11024           
  Partials      172      172
Impacted Files Coverage Δ
app/dashboard/views.py 11.93% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c51ad...7690174. Read the comment docs.

h2,
h3,
h4 {
font-family: Arial-Black, Helvetica, sans-serif;
Copy link
Member

@thelostone-mc thelostone-mc Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new font-family ? I thought we were using Muli throughout the site :P
we can just add g-font-muli class to the body

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in this design, is something separated, also without the top navbar and footer

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Left a few minor comments

@thelostone-mc thelostone-mc merged commit da63217 into master Mar 19, 2019
@thelostone-mc thelostone-mc deleted the hacklanding-fixes branch March 19, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants