Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethhack2019 #3974

Merged
merged 30 commits into from
Mar 15, 2019
Merged

Ethhack2019 #3974

merged 30 commits into from
Mar 15, 2019

Conversation

deeayeen
Copy link
Contributor

Description

Add ethhack 2019 landing page.

Checklist
Affected core subsystem(s)
Refers/Fixes

3958

Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #3974 into master will decrease coverage by 0.03%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3974      +/-   ##
==========================================
- Coverage   30.01%   29.97%   -0.04%     
==========================================
  Files         205      205              
  Lines       15994    15998       +4     
  Branches     2111     2111              
==========================================
- Hits         4801     4796       -5     
- Misses      11021    11030       +9     
  Partials      172      172
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
app/dashboard/views.py 11.93% <20%> (+0.05%) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdae2b...389a355. Read the comment docs.

@octavioamu
Copy link
Contributor

octavioamu commented Mar 15, 2019

to center elements for example instead of position absolute you can take a look how it was used here
https://github.com/gitcoinco/web/blob/master/app/dashboard/templates/social_contribution_modal.html (go to a bounty and press share to see it alive)
Or even better coded check kudos landing https://gitcoin.co/kudos/

<div class="row justify-content-center pb-5">
    <div class="col-12 col-md-6">
           this box will be center and half of the screen in desktop and 100% in mobile 
    </div>
</div>

octavioamu
octavioamu previously approved these changes Mar 15, 2019
@octavioamu
Copy link
Contributor

Thanks @deeayeen finally can you add the links?
Here is the hacker link https://gitcoin.typeform.com/to/j7CSbV
And sponsor https://gitcoin.typeform.com/to/YeIflB

@octavioamu octavioamu merged commit fe15726 into gitcoinco:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants