Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search to verified #3965

Merged
merged 1 commit into from
Mar 13, 2019
Merged

add search to verified #3965

merged 1 commit into from
Mar 13, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Mar 13, 2019

Description

https://share.vidyard.com/watch/MtX171UY6PAzs6p9pMRB2h

Checklist
Affected core subsystem(s)
Refers/Fixes

Refs #3963

Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #3965 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3965      +/-   ##
==========================================
+ Coverage   30.01%   30.01%   +<.01%     
==========================================
  Files         205      205              
  Lines       15951    15953       +2     
  Branches     2108     2108              
==========================================
+ Hits         4787     4789       +2     
  Misses      10992    10992              
  Partials      172      172
Impacted Files Coverage Δ
app/dashboard/admin.py 72.72% <100%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c537d9...e27d739. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #3965 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3965      +/-   ##
==========================================
+ Coverage   30.01%   30.01%   +<.01%     
==========================================
  Files         205      205              
  Lines       15951    15953       +2     
  Branches     2108     2108              
==========================================
+ Hits         4787     4789       +2     
  Misses      10992    10992              
  Partials      172      172
Impacted Files Coverage Δ
app/dashboard/admin.py 72.72% <100%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c537d9...e27d739. Read the comment docs.

@owocki owocki merged commit 38d65b6 into master Mar 13, 2019
@thelostone-mc thelostone-mc deleted the search-verified branch March 27, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants