bounties: fee integration

[thelostone-mc]

Description

• Bounty Fee Integration
• Refund Fee Flow
• Metamask notification
• Ensure db isn't updated when user selects featured bounty and then rejects bounty

Check out gist for info

closes #3891
closes #3910
closes #3909

Pending: @frankchen07

• email wiring (designs needed)
• enabling fee for increase bounty fee (design needed)

[codecov]

Codecov Report

Merging #3961 into master will increase coverage by 0.02%.
The diff coverage is 35.06%.

@@            Coverage Diff             @@
##           master    #3961      +/-   ##
==========================================
+ Coverage      30%   30.02%   +0.02%     
==========================================
  Files         205      205              
  Lines       15950    16025      +75     
  Branches     2108     2116       +8     
==========================================
+ Hits         4786     4812      +26     
- Misses      10992    11041      +49     
  Partials      172      172

Impacted Files	Coverage Δ
app/app/urls.py	90% <ø> (ø)	⬆️
app/dashboard/helpers.py	16.03% <0%> (-0.29%)	⬇️
app/dashboard/views.py	12.13% <13.04%> (+0.05%)	⬆️
app/dashboard/admin.py	72.09% <70%> (-0.18%)	⬇️
app/dashboard/models.py	53.74% <93.33%> (+0.39%)	⬆️
app/grants/views.py	12.41% <0%> (-0.29%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb901de...7eb034e. Read the comment docs.

[codecov]

Codecov Report

Merging #3961 into master will increase coverage by 0.02%.
The diff coverage is 35.55%.

@@            Coverage Diff             @@
##           master    #3961      +/-   ##
==========================================
+ Coverage   30.19%   30.22%   +0.02%     
==========================================
  Files         205      205              
  Lines       16150    16240      +90     
  Branches     2129     2139      +10     
==========================================
+ Hits         4876     4908      +32     
- Misses      11100    11158      +58     
  Partials      174      174

Impacted Files	Coverage Δ
app/app/urls.py	90% <ø> (ø)	⬆️
app/dashboard/helpers.py	15.44% <0%> (-0.27%)	⬇️
app/dashboard/views.py	12.13% <11.36%> (-0.04%)	⬇️
app/dashboard/admin.py	68.09% <52%> (-2.92%)	⬇️
app/dashboard/models.py	54.2% <93.33%> (+0.38%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5482e1...b5f32af. Read the comment docs.

[frankchen07]

@danlipert @thelostone-mc

First off, great work. Thanks for the amazing teamwork on this, and working through the decisions on contracts and stuff. +1 for Dan putting it up on staging 5 minutes after I asked for it too. Just finished looking at this on staging, and the functioning looks smooth. Some comments below from Aditya's asks.

1. We'll hold off on the email designs. Because this is a lightweight test, I would say we can remove the "request fee refund" option on the issue details page. If they decide to cancel, they can contact us via email / feedback for refunds and we can deal with it ad-hoc. Since we have the code for it already, we can always reactivate it when necessary. Our goal here is to gauge reactions and see what happens.

2. For the fee charge when increasing the bounty amount, I actually don't see an option to increase the bounty amount (example below). That being said, this is also an edge case that we don't need to worry about as of right now for the purposes of this revenue test. My hypothesis is that the majority of folks posting on Gitcoin aren't trying to game the system.

3. I know we store featured bounty revenue in our DB, is the % fee also stored in our DB, and does it have a corresponding bounty_id that we can link to? This is mainly for data reporting purposes, as well as having the proper information to process refunds if necessary from our admin.

[thelostone-mc]

@frankchen07

actually don't see an option to increase the bounty amount (example below).

The increase bounty is the contribute button & I've seen it used by a few funders.
Click on contribute -> and then increase funding.
Every bounty has this option available to the bounty funder.
I've got the code nearly done but I can revert it if we still feel it's not needed

is the % fee also stored in our DB, and does it have a corresponding bounty_id that we can link to?

we store the % fee directly in the bounty table as shown here

[octavioamu]

Didn't test it in my local to understand deeply but left some comments

threw in comments to address review comments