Issue 3937 notification email #3959

iamonuwa · 2019-03-12T20:47:49Z

Description

Send weekly unread notification emails

Checklist

Read and conforms to the contributor guidelines
Read and conforms to the style guidelines
Linter status: 100% pass
Added relevant tests
Tests pass and code coverage has not decreased
Changes don't break existing behavior
Commit message follows commit guidelines
Code documentation
Completed: Code review by core team and any requested changes

Affected core subsystem(s)

Refers/Fixes

Fixes #3937

Testing and Sign-off

Contributor

Read and followed the Contributor Guidelines
Tested all changes locally
Verified existing functionality
Ran make test and everything passed!

Reviewer

Affirm contributor guidelines have been followed and requested changes made
CI tests and linting pass
No conflicts (migrations, files, etc)
Regression tested against staging or local deployment

Funder

Validated requested changes were made to specification
Bounty payout released to the contributor

codecov · 2019-03-13T17:48:19Z

Codecov Report

Merging #3959 into master will decrease coverage by 0.09%.
The diff coverage is 20.51%.

@@            Coverage Diff            @@
##           master    #3959     +/-   ##
=========================================
- Coverage   30.01%   29.91%   -0.1%     
=========================================
  Files         205      206      +1     
  Lines       15951    16026     +75     
  Branches     2108     2117      +9     
=========================================
+ Hits         4787     4794      +7     
- Misses      10992    11060     +68     
  Partials      172      172

Impacted Files	Coverage Δ
app/app/urls.py	`90% <ø> (ø)`	⬆️
app/dashboard/views.py	`12.08% <100%> (ø)`	⬆️
app/retail/emails.py	`21.13% <12.5%> (-0.24%)`	⬇️
...ommands/send_unread_notification_emails_roundup.py	`25% <25%> (ø)`
app/marketing/mails.py	`13% <7.69%> (-0.11%)`	⬇️
app/dashboard/embed.py	`28.16% <0%> (-3.45%)`	⬇️
app/grants/views.py	`12.41% <0%> (-0.57%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484d19d...356c985. Read the comment docs.

codecov · 2019-03-13T17:48:20Z

Codecov Report

Merging #3959 into master will increase coverage by 0.02%.
The diff coverage is 43.24%.

@@            Coverage Diff             @@
##           master    #3959      +/-   ##
==========================================
+ Coverage   30.22%   30.25%   +0.02%     
==========================================
  Files         205      206       +1     
  Lines       16236    16310      +74     
  Branches     2136     2145       +9     
==========================================
+ Hits         4908     4934      +26     
- Misses      11154    11200      +46     
- Partials      174      176       +2

Impacted Files	Coverage Δ
app/dashboard/views.py	`12.13% <ø> (ø)`	⬆️
app/app/urls.py	`90% <ø> (ø)`	⬆️
app/retail/emails.py	`21.56% <12.5%> (-0.26%)`	⬇️
...ommands/send_unread_notification_emails_roundup.py	`64.44% <64.44%> (ø)`
app/marketing/mails.py	`13% <7.69%> (-0.11%)`	⬇️
app/dashboard/embed.py	`28.16% <0%> (-3.45%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1736f64...3cf0662. Read the comment docs.

thelostone-mc · 2019-03-13T17:48:35Z

@iamonuwa i see tests \m/
btw could you throw in a screenshot of the mail too ?

iamonuwa · 2019-03-13T19:18:04Z

@iamonuwa i see tests \m/
btw could you throw in a screenshot of the mail too ?

Will send it in tomorrow, am AFK at the moment.

PixelantDesign · 2019-03-13T19:46:41Z

@thelostone-mc let me know when good to pay out!

iamonuwa · 2019-03-14T09:20:24Z

iamonuwa · 2019-03-14T09:22:31Z

cc: @thelostone-mc

app/marketing/mails.py

app/marketing/management/commands/send_unread_notification_emails_roundup.py

thelostone-mc · 2019-03-19T06:50:36Z

@iamonuwa mind addressing the comments left by @rafalkowalski + rebase with master ? ^_^
@PixelantDesign #3959 (comment) look good ?

iamonuwa · 2019-03-19T07:39:55Z

@iamonuwa mind addressing the comments left by @rafalkowalski + rebase with master ? ^_^
@PixelantDesign #3959 (comment) look good ?

Yes, will make changes to reflect the review

thelostone-mc

Looks good ^_^
Thanks @iamonuwa & @rafalkowalski :)

thelostone-mc · 2019-03-21T13:05:15Z

@iamonuwa we've got CI failures ! mind fixing them up ?

iamonuwa · 2019-03-21T13:28:34Z

@iamonuwa we've got CI failures ! mind fixing them up ?

Aye captain!

thelostone-mc · 2019-03-23T11:36:56Z

@iamonuwa lemme know when CI is green ^_^

iamonuwa · 2019-03-24T15:45:59Z

@iamonuwa lemme know when CI is green ^_^

Working on it

iamonuwa · 2019-03-29T02:07:48Z

cc: @thelostone-mc

SaptakS

LGTM. @thelostone-mc any last comments?

thelostone-mc · 2019-04-01T14:43:26Z

app/retail/emails.py

+def unread_notification_email_weekly_roundup(request):
+    response_html, _ = render_unread_notification_email_weekly_roundup('[email protected]')
+    return HttpResponse(response_html)
+


we need an extra empty line (keeping it consistent )

gitcoinbot mentioned this pull request Mar 12, 2019

Build Notification Email #3937

Closed

9 tasks

rafalkowalski reviewed Mar 16, 2019

View reviewed changes

thelostone-mc previously approved these changes Mar 21, 2019

View reviewed changes

iamonuwa dismissed thelostone-mc’s stale review via 0e211e8 March 22, 2019 09:45

iamonuwa added 8 commits March 29, 2019 02:45

Add notification email cron task

b910bf3

Update email template

d99c836

Update email template

37d1cda

Update tests

38b16fb

Update test

517d7f1

Update changes

b81699a

Update changes

fec5502

Fix tests

7ca45f4

PixelantDesign requested a review from danlipert March 29, 2019 12:10

Merge branch 'master' into issue-3937-notification-email

3cf0662

SaptakS approved these changes Apr 1, 2019

View reviewed changes

thelostone-mc reviewed Apr 1, 2019

View reviewed changes

SaptakS merged commit 6fa7f37 into gitcoinco:master Apr 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 3937 notification email #3959

Issue 3937 notification email #3959

iamonuwa commented Mar 12, 2019 •

edited

Loading

codecov bot commented Mar 13, 2019

codecov bot commented Mar 13, 2019 •

edited

Loading

thelostone-mc commented Mar 13, 2019

iamonuwa commented Mar 13, 2019

PixelantDesign commented Mar 13, 2019

iamonuwa commented Mar 14, 2019

iamonuwa commented Mar 14, 2019

thelostone-mc commented Mar 19, 2019

iamonuwa commented Mar 19, 2019

thelostone-mc left a comment

thelostone-mc commented Mar 21, 2019

iamonuwa commented Mar 21, 2019

thelostone-mc commented Mar 23, 2019

iamonuwa commented Mar 24, 2019

iamonuwa commented Mar 29, 2019

SaptakS left a comment

thelostone-mc Apr 1, 2019

Issue 3937 notification email #3959

Issue 3937 notification email #3959

Conversation

iamonuwa commented Mar 12, 2019 • edited Loading

Description

Checklist

Affected core subsystem(s)

Refers/Fixes

Testing and Sign-off

Contributor

Reviewer

Funder

codecov bot commented Mar 13, 2019

Codecov Report

codecov bot commented Mar 13, 2019 • edited Loading

Codecov Report

thelostone-mc commented Mar 13, 2019

iamonuwa commented Mar 13, 2019

PixelantDesign commented Mar 13, 2019

iamonuwa commented Mar 14, 2019

iamonuwa commented Mar 14, 2019

thelostone-mc commented Mar 19, 2019

iamonuwa commented Mar 19, 2019

thelostone-mc left a comment

Choose a reason for hiding this comment

thelostone-mc commented Mar 21, 2019

iamonuwa commented Mar 21, 2019

thelostone-mc commented Mar 23, 2019

iamonuwa commented Mar 24, 2019

iamonuwa commented Mar 29, 2019

SaptakS left a comment

Choose a reason for hiding this comment

thelostone-mc Apr 1, 2019

Choose a reason for hiding this comment

iamonuwa commented Mar 12, 2019 •

edited

Loading

codecov bot commented Mar 13, 2019 •

edited

Loading