Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hackathon #3942

Merged
merged 28 commits into from
Mar 27, 2019
Merged

hackathon #3942

merged 28 commits into from
Mar 27, 2019

Conversation

octavioamu
Copy link
Contributor

Description

From #2267

Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

pinkiebell and others added 5 commits December 11, 2018 09:47
Fixes #2171

V0 Hackathon: addressing pr comments
V0 Hackathon: more fixes
V0 Hackathon: 00:42AM. RegExp braindrain
V0 Hackathon: Resolving pr comments
V0 Hackathon: Remove prize_* properties
V0 Hackathon: Addressing PR comments
V0 Hackathon: lint
V0 Hackathon/bounty funding form: checkbox + event selection
Hackathon V0: rebase fix
Hackathon V0: propagate the event_tag for bounty_details
Hackathon V0: another template rebase fix
Hackathon V0: SlugField
Hackathon V0: fix rebase
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #3942 into master will decrease coverage by <.01%.
The diff coverage is 31.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3942      +/-   ##
==========================================
- Coverage   30.19%   30.19%   -0.01%     
==========================================
  Files         205      205              
  Lines       16085    16148      +63     
  Branches     2123     2129       +6     
==========================================
+ Hits         4857     4876      +19     
- Misses      11054    11098      +44     
  Partials      174      174
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
app/dashboard/router.py 30.89% <0%> (-1.36%) ⬇️
app/dashboard/helpers.py 15.71% <11.11%> (-0.37%) ⬇️
app/dashboard/views.py 12.16% <15.78%> (+0.06%) ⬆️
app/dashboard/admin.py 71.01% <46.15%> (-2.59%) ⬇️
app/dashboard/models.py 53.82% <66.66%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76423a...37687b7. Read the comment docs.

app/dashboard/admin.py Show resolved Hide resolved
app/dashboard/templates/dashboard/hackathons.html Outdated Show resolved Hide resolved
app/dashboard/templates/bounty/new.html Show resolved Hide resolved
app/dashboard/templates/bounty/new.html Show resolved Hide resolved
app/assets/v2/js/pages/dashboard.js Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
@thelostone-mc thelostone-mc dismissed danlipert’s stale review March 27, 2019 06:03

Discussed with @Octavio -> It's the select2 data not getting the data. Happens on local every now and then

@thelostone-mc thelostone-mc merged commit 5ca2520 into master Mar 27, 2019
@thelostone-mc thelostone-mc deleted the hackathon branch March 27, 2019 15:59
@SaptakS SaptakS changed the title [WIP] Hackathon hackathon Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants