Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kudos section to modal #3906

Merged
merged 15 commits into from
Mar 14, 2019
Merged

add kudos section to modal #3906

merged 15 commits into from
Mar 14, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Mar 6, 2019

Description

image

Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #3906 into master will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3906      +/-   ##
==========================================
+ Coverage   29.91%   30.98%   +1.07%     
==========================================
  Files         203      203              
  Lines       15820    17313    +1493     
  Branches     2085     2533     +448     
==========================================
+ Hits         4733     5365     +632     
- Misses      10922    11727     +805     
- Partials      165      221      +56
Impacted Files Coverage Δ
app/app/urls.py 86.2% <0%> (-3.8%) ⬇️
app/dashboard/router.py 25% <0%> (-1.46%) ⬇️
app/dashboard/utils.py 33.84% <0%> (-1.36%) ⬇️
app/retail/emails.py 23.32% <0%> (+0.48%) ⬆️
app/dashboard/views.py 14.08% <0%> (+1.98%) ⬆️
app/marketing/mails.py 16.66% <0%> (+2.11%) ⬆️
app/avatar/utils.py 15.92% <0%> (+2.23%) ⬆️
app/app/utils.py 24.27% <0%> (+3.08%) ⬆️
app/git/utils.py 45.27% <0%> (+3.49%) ⬆️
app/dashboard/models.py 59.42% <0%> (+5.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856e142...0b168e8. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #3906 into master will decrease coverage by <.01%.
The diff coverage is 25.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3906      +/-   ##
==========================================
- Coverage   30.01%   30.01%   -0.01%     
==========================================
  Files         205      205              
  Lines       15953    15994      +41     
  Branches     2108     2111       +3     
==========================================
+ Hits         4789     4801      +12     
- Misses      10992    11021      +29     
  Partials      172      172
Impacted Files Coverage Δ
app/dashboard/views.py 11.88% <0%> (-0.21%) ⬇️
app/dashboard/admin.py 73.59% <100%> (+0.87%) ⬆️
app/dashboard/utils.py 35.2% <22.22%> (ø) ⬆️
app/dashboard/models.py 53.45% <66.66%> (+0.1%) ⬆️
app/dashboard/router.py 25.15% <9.09%> (-1.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d65b6...362f1c6. Read the comment docs.

@PixelantDesign
Copy link
Contributor

awesome!

@octavioamu octavioamu requested a review from SaptakS March 11, 2019 19:49
@octavioamu
Copy link
Contributor Author

Tested in local but the entry is only created if is shared by looking for a user, not when you share the link in social networks or direct, in this case is givin an error. I think the entry need to have some reference to the one who invited and create the entry when someone gets in using it.

@SaptakS
Copy link
Contributor

SaptakS commented Mar 14, 2019

@octavioamu When you are sharing a link, you have to share the link in this text:

Check out this bounty that pays out 0.001 ETH http://localhost:8000/issue/U2FwdGFrU1g5NmdSQVZ2d3g1MnVTNnc0UVlDVUhSZlIzT2FvQjE=  #Smarty

If you share the normal URL, obviously it can't be tracked.

@PixelantDesign currently it's shown like this:

Screen Shot 2019-03-14 at 9 41 37 AM

Let me know if there needs to be a UI/UX update to show the shareable link more prominently rather than in the text.

cc: @willsputra

@SaptakS
Copy link
Contributor

SaptakS commented Mar 14, 2019

@PixelantDesign @octavioamu @willsputra Updated the message and the link in the social shares to include the same hashed URL link so we can track the invite.

@SaptakS SaptakS merged commit efdae2b into master Mar 14, 2019
@thelostone-mc thelostone-mc deleted the share-w-kudos branch March 14, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants