-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kudos section to modal #3906
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3906 +/- ##
==========================================
+ Coverage 29.91% 30.98% +1.07%
==========================================
Files 203 203
Lines 15820 17313 +1493
Branches 2085 2533 +448
==========================================
+ Hits 4733 5365 +632
- Misses 10922 11727 +805
- Partials 165 221 +56
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3906 +/- ##
==========================================
- Coverage 30.01% 30.01% -0.01%
==========================================
Files 205 205
Lines 15953 15994 +41
Branches 2108 2111 +3
==========================================
+ Hits 4789 4801 +12
- Misses 10992 11021 +29
Partials 172 172
Continue to review full report at Codecov.
|
awesome! |
Tested in local but the entry is only created if is shared by looking for a user, not when you share the link in social networks or direct, in this case is givin an error. I think the entry need to have some reference to the one who invited and create the entry when someone gets in using it. |
@octavioamu When you are sharing a link, you have to share the link in this text:
If you share the normal URL, obviously it can't be tracked. @PixelantDesign currently it's shown like this: Let me know if there needs to be a UI/UX update to show the shareable link more prominently rather than in the text. cc: @willsputra |
@PixelantDesign @octavioamu @willsputra Updated the message and the link in the social shares to include the same hashed URL link so we can track the invite. |
Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
make test
and everything passed!Reviewer
Funder