Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore previous default logging behavior, cleanup logging setup, upgrade Sentry SDK #3837

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

danlipert
Copy link
Contributor

@danlipert danlipert commented Feb 25, 2019

Description

This PR upgrades the Sentry SDK to the latest version, which has a simpler setup.

Checklist
Affected core subsystem(s)

logging, error reporting

Refers/Fixes

Fixes: #3887 #3809

Testing and Sign-off

Tested locally with hosted sentry environment

Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment

@danlipert danlipert force-pushed the sentry-logging-fix-it-twice branch from 8fdbe5b to 1e0754b Compare March 12, 2019 11:46
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #3837 into master will increase coverage by 0.04%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3837      +/-   ##
==========================================
+ Coverage   30.03%   30.07%   +0.04%     
==========================================
  Files         205      205              
  Lines       15996    16000       +4     
  Branches     2111     2109       -2     
==========================================
+ Hits         4804     4812       +8     
+ Misses      11020    11017       -3     
+ Partials      172      171       -1
Impacted Files Coverage Δ
app/app/settings.py 78.07% <23.07%> (-0.44%) ⬇️
app/app/log_filters.py 75% <0%> (+75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b7f8e...22a033f. Read the comment docs.

@danlipert danlipert force-pushed the sentry-logging-fix-it-twice branch 3 times, most recently from 248dd1d to 9608908 Compare March 19, 2019 09:00
@danlipert danlipert changed the title [WIP] cleanup logging setup Restore previous default logging behavior, cleanup logging setup, upgrade Sentry SDK Mar 19, 2019
@danlipert danlipert force-pushed the sentry-logging-fix-it-twice branch from fa739b6 to b423f5b Compare March 19, 2019 09:24
@danlipert danlipert force-pushed the sentry-logging-fix-it-twice branch from b423f5b to 7a31e6d Compare March 21, 2019 11:30
@thelostone-mc thelostone-mc merged commit 8cd6b4a into master Mar 21, 2019
@thelostone-mc thelostone-mc deleted the sentry-logging-fix-it-twice branch March 27, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants