Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Avatar Items #3797

Merged
merged 4 commits into from
Feb 21, 2019
Merged

New Avatar Items #3797

merged 4 commits into from
Feb 21, 2019

Conversation

yashmathne
Copy link
Contributor

Description

Hey!

I've created multiple new avatar items that go with the color scheme.
The items include:

1 ) Power Rangers Inspired Mask
screenshot 2019-02-21 at 5 40 10 pm

2 ) Funky Glasses
screenshot 2019-02-21 at 5 40 32 pm

3 ) Classic Glasses
screenshot 2019-02-21 at 5 57 19 pm

4 ) Devil Horns
screenshot 2019-02-21 at 5 41 20 pm

5 ) Angel's Halo
screenshot 2019-02-21 at 5 49 52 pm

6 ) Classic Necklace
screenshot 2019-02-21 at 5 54 10 pm

7 ) Casual Necklace
screenshot 2019-02-21 at 5 54 17 pm

8 ) Beach Necklace
screenshot 2019-02-21 at 5 54 28 pm

Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #3797 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3797      +/-   ##
==========================================
- Coverage   29.57%   29.51%   -0.06%     
==========================================
  Files         199      199              
  Lines       15380    15353      -27     
  Branches     2008     2006       -2     
==========================================
- Hits         4548     4531      -17     
+ Misses      10680    10670      -10     
  Partials      152      152
Impacted Files Coverage Δ
app/avatar/utils.py 14.8% <ø> (ø) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️
app/kudos/admin.py 67.27% <0%> (-2.73%) ⬇️
app/kudos/models.py 56.14% <0%> (-0.33%) ⬇️
app/grants/views.py 12.71% <0%> (-0.3%) ⬇️
app/grants/models.py 49.39% <0%> (-0.21%) ⬇️
app/grants/management/commands/subminer.py 0% <0%> (ø) ⬆️
...agement/commands/send_tips_for_bounty_fulfiller.py 0% <0%> (ø) ⬆️
app/kudos/views.py 22.39% <0%> (+0.34%) ⬆️
app/event_ethdenver2019/views.py 21.91% <0%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2e345...a76e4f8. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #3797 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3797   +/-   ##
=======================================
  Coverage   29.55%   29.55%           
=======================================
  Files         199      199           
  Lines       15353    15353           
  Branches     2006     2006           
=======================================
  Hits         4537     4537           
  Misses      10664    10664           
  Partials      152      152
Impacted Files Coverage Δ
app/avatar/utils.py 14.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2220f0c...382ac09. Read the comment docs.

@yashmathne yashmathne mentioned this pull request Feb 21, 2019
5 tasks
@yashmathne
Copy link
Contributor Author

Added two new accessories,

1 ) 3D Glasses
screenshot 2019-02-21 at 8 29 59 pm

2 ) Clown/Joker Mask
screenshot 2019-02-21 at 8 30 20 pm

@thelostone-mc thelostone-mc merged commit 3064e74 into gitcoinco:master Feb 21, 2019
@owocki
Copy link
Contributor

owocki commented Feb 21, 2019

so dope @yash412 ! keep it up :) let me know how much i owe you and ill tip you out on this PR

@yashmathne
Copy link
Contributor Author

Glad you liked them @owocki!

At 15$/Accessory, you owe me 150$. I personally think two of these are exotic, so anywhere between 150$ - 160$.

Thanks in advance.

@gitcoinbot
Copy link
Member

⚡️ A tip worth 1.10000 ETH (159.28 USD @ $144.8/ETH) has been granted to @yash412 for this issue from @owocki. ⚡️

Nice work @yash412! Your tip has automatically been deposited in the ETH address we have on file.

@gitcoinbot
Copy link
Member

Eye For Detail ⚡️ A *Eye For Detail* Kudos has been sent to @yash412 for this issue from @owocki. ⚡️

Nice work @yash412!
Your Kudos has automatically been sent in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants