Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carnival #3733

Merged
merged 4 commits into from
Feb 19, 2019
Merged

Carnival #3733

merged 4 commits into from
Feb 19, 2019

Conversation

j0ker1234
Copy link
Contributor

@j0ker1234 j0ker1234 commented Feb 12, 2019

Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@j0ker1234
Copy link
Contributor Author

image

image

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #3733 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3733   +/-   ##
=======================================
  Coverage   29.54%   29.54%           
=======================================
  Files         199      199           
  Lines       15332    15332           
  Branches     2006     2006           
=======================================
  Hits         4530     4530           
  Misses      10650    10650           
  Partials      152      152
Impacted Files Coverage Δ
app/avatar/utils.py 14.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e565f5...70ff6ad. Read the comment docs.

@j0ker1234 j0ker1234 mentioned this pull request Feb 12, 2019
5 tasks
@thelostone-mc
Copy link
Member

@j0ker1234 that looks pretty dope ! can you resolve the conflicts though ?

@thelostone-mc
Copy link
Member

@j0ker1234 wanna get this in this week ?

@j0ker1234
Copy link
Contributor Author

@thelostone-mc I am working on some more designs, will submit a pr by Friday.

@j0ker1234
Copy link
Contributor Author

@thelostone-mc I have resolved the conflicts for this branch. For the other designs will create a new pr.

@j0ker1234 j0ker1234 mentioned this pull request Feb 19, 2019
19 tasks
@thelostone-mc
Copy link
Member

@j0ker1234 Ah merging your other PR introduced conflicts here again 😅 Mind resolving them again?

@j0ker1234
Copy link
Contributor Author

@thelostone-mc Done.

@owocki owocki merged commit 8f1b146 into gitcoinco:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants