-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carnival #3733
Carnival #3733
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3733 +/- ##
=======================================
Coverage 29.54% 29.54%
=======================================
Files 199 199
Lines 15332 15332
Branches 2006 2006
=======================================
Hits 4530 4530
Misses 10650 10650
Partials 152 152
Continue to review full report at Codecov.
|
@j0ker1234 that looks pretty dope ! can you resolve the conflicts though ? |
@j0ker1234 wanna get this in this week ? |
@thelostone-mc I am working on some more designs, will submit a pr by Friday. |
@thelostone-mc I have resolved the conflicts for this branch. For the other designs will create a new pr. |
@j0ker1234 Ah merging your other PR introduced conflicts here again 😅 Mind resolving them again? |
@thelostone-mc Done. |
Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
make test
and everything passed!Reviewer
Funder