Use ImageOps.fit instead of Image.thumbnail #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scaled up if they are small Fixes: gitcoinco#355
poffdeluxe
changed the title
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 23.62% 23.62% +<.01%
==========================================
Files 87 87
Lines 4123 4122 -1
Branches 492 492
==========================================
Hits 974 974
+ Misses 3141 3140 -1
Partials 8 8
Continue to review full report at Codecov.
|
|
LGTM |
mbeacom
approved these changes
Feb 1, 2018
There was a problem hiding this comment.
lgtm 
Thanks for the contribution!
Just a note, I made a change to local_avatar_url to ensure local and staging will reference the appropriate URL (versus always referencing https://gitcoin.co/) in b572fa6 - Tested this following the change. 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #355
Description
Now scales avatar photos by using ImageOps.fit instead of Image.thumbnail because Image.thumbnail will modify the image only if is larger than the given size.
Before:
After:
As this is my first PR contributing to this repo, please let me know if I missed anything or if I need to include more data here. I read the CONTRIBUTING.md guide but I'm nervous I missed something 😬
Checklist
Affected core subsystem(s)
dashboard/embed
Refers/Fixes
Fixes #355