Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html: replaced slack image with font-awesome icon #333

Merged
merged 3 commits into from
Jan 31, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jan 30, 2018

Description

replaced img with font-awesome -> page loads a tad bit faster
If this is alright, will do it in batches so as to use icons rather than images + refactor along the way

  • replaced slack image with slack font-awesome
  • re-indented nav
  • noticed that nav bars have different size on different pages, so evened it out
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • html

@codecov
Copy link

codecov bot commented Jan 30, 2018

Codecov Report

Merging #333 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   23.56%   23.54%   -0.02%     
==========================================
  Files          82       82              
  Lines        4083     4082       -1     
  Branches      491      491              
==========================================
- Hits          962      961       -1     
  Misses       3113     3113              
  Partials        8        8
Impacted Files Coverage Δ
app/dashboard/models.py 39.17% <0%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ef568...259dbe3. Read the comment docs.

@owocki
Copy link
Contributor

owocki commented Jan 30, 2018

as youre submitting these frontend PRs it might be nice to see screenshots of your work without having to pull the branch :)

@thelostone-mc
Copy link
Member Author

@owocki Yeah I was getting to that 😅

@thelostone-mc thelostone-mc mentioned this pull request Jan 31, 2018
3 tasks
@thelostone-mc
Copy link
Member Author

Most pages in gitcoin have a navbar of this size:

screen shot 2018-01-30 at 5 08 43 pm

But pages like the landing, help have a larger nav bar

screen shot 2018-01-30 at 5 08 57 pm

After fix:

screen shot 2018-01-30 at 5 09 11 pm

@thelostone-mc
Copy link
Member Author

@owocki review + merge ?

@owocki
Copy link
Contributor

owocki commented Jan 31, 2018

thanks!

@owocki owocki merged commit 2583518 into gitcoinco:master Jan 31, 2018
@thelostone-mc thelostone-mc deleted the img-font-awesome branch February 20, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants