qa+ corner cases #2997
Merged
qa+ corner cases #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed gitcoin_bot shrug + added grants white svg - added grant white svg icon to landing page - redirects to error page when user tries to fund / cancel subscription on inactive grant - redirects to error page when user tried to cancel already cancelled subscription
- updated youtube link + text on index - update quickstart info - fix nav dropdown on hover on stub page Refs: gitcoinco#2949
thelostone-mc
requested review from
owocki,
mbeacom,
SaptakS,
willsputra and
captnseagraves
stickler-ci
reviewed
Nov 29, 2018
mbeacom
reviewed
Nov 29, 2018
Codecov Report
@@ Coverage Diff @@
## grantz #2997 +/- ##
==========================================
+ Coverage 30.03% 30.26% +0.23%
==========================================
Files 190 190
Lines 14490 14219 -271
Branches 1931 1870 -61
==========================================
- Hits 4352 4304 -48
+ Misses 9994 9777 -217
+ Partials 144 138 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
subscription on inactive grant
cancelled subscription
QA + fixes
Refers/Fixes