Add cancel modal on cancelling grants #2995
Conversation
SaptakS
force-pushed
the
cancel_modal_grants
branch
from
7c0fb29 to
7c800e5
Compare
Codecov Report
@@ Coverage Diff @@
## grantz #2995 +/- ##
=========================================
- Coverage 30.21% 30.2% -0.02%
=========================================
Files 190 190
Lines 14264 14225 -39
Branches 1881 1872 -9
=========================================
- Hits 4310 4296 -14
+ Misses 9815 9791 -24
+ Partials 139 138 -1
Continue to review full report at Codecov.
|
mbeacom
added
frontend
|
@SaptakS conflicts |
mbeacom
changed the title
| @@ -70,6 +110,7 @@ $(document).ready(function() { | |||
| .send({from: accounts[0], gasPrice: 4000000000}) | |||
| .on('transactionHash', function() { | |||
| document.issueURL = document.getElementById('grant-link').href; | |||
| $('.modal .close').trigger('click'); | |||
| enableWaitState('#grants-details'); | |||
| }) | |||
| .on('confirmation', function(confirmationNumber, receipt) { | |||
There was a problem hiding this comment.
Im worry about how we are doing this if someone decide to reload the page in the waitState we have some kind of mechanist to check if the grants is sync?
There was a problem hiding this comment.
I think this question is there in all the pages if someone refreshes at this stage. It will show the particular page instead of the waiting state. I think not related to this PR. But I will check on it.
There was a problem hiding this comment.
yes yes agree is not related at all but yesterday was looking the cancel code and started to think about the closed grants in blockchain but not in our db
SaptakS
force-pushed
the
cancel_modal_grants
branch
from
3d9f115 to
11d3ce4
Compare
mbeacom
changed the title
There was a problem hiding this comment.
Can we hold on merging this until #3012 gets merged? Where the modal is fired and how the form is being submitted will change with the above PR.
|
@captnseagraves sure. |
SaptakS
force-pushed
the
cancel_modal_grants
branch
from
11d3ce4 to
99c18db
Compare
|
@mbeacom @captnseagraves @thelostone-mc please have a look one last time. :) |
Description
Adds cancel modal based on the design by @willsputra
Checklist
Affected core subsystem(s)
Testing
Refers/Fixes