-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2746 - Makeup causing issues aswell #2968
Conversation
app/avatar/utils.py
Outdated
src = transform.fromfile(f'{COMPONENT_BASE}{path}') | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W293 blank line contains whitespace
app/avatar/utils.py
Outdated
# else: | ||
# src_width = 900 | ||
if src.width is not None: | ||
src_width = float(re.sub('[^0-9]','', src.width)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E231 missing whitespace after ','
app/avatar/utils.py
Outdated
|
||
if src.height is not None: | ||
src_height = float(re.sub('[^0-9]', '', src.height)) | ||
else: | ||
src_height = 1415 | ||
scale_factor = icon_size[1] / src_height | ||
if path.startswith('Makeup'): | ||
scale_factor = scale_factor / 2 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W293 blank line contains whitespace
app/avatar/utils.py
Outdated
if path.startswith('Makeup'): | ||
x_to_center = (icon_size[0] / 2) - ((src_width * scale_factor) / 2) | ||
svg = svg.move(x_to_center, src_height * scale_factor / 2) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W293 blank line contains whitespace
@kuhnchris could you resolve the stickler errors? ^_^ |
Codecov Report
@@ Coverage Diff @@
## master #2968 +/- ##
==========================================
- Coverage 29.78% 29.72% -0.07%
==========================================
Files 180 180
Lines 13720 13728 +8
Branches 1839 1842 +3
==========================================
- Hits 4086 4080 -6
- Misses 9496 9510 +14
Partials 138 138
Continue to review full report at Codecov.
|
Do I have to? Awww. 😭 Anyways, fix inbound! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @kuhnchris
|
see #2746 (comment)