Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2746 - Makeup causing issues aswell #2968

Merged
merged 5 commits into from
Nov 30, 2018
Merged

Fix #2746 - Makeup causing issues aswell #2968

merged 5 commits into from
Nov 30, 2018

Conversation

kuhnchris
Copy link
Contributor

src = transform.fromfile(f'{COMPONENT_BASE}{path}')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W293 blank line contains whitespace

# else:
# src_width = 900
if src.width is not None:
src_width = float(re.sub('[^0-9]','', src.width))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E231 missing whitespace after ','


if src.height is not None:
src_height = float(re.sub('[^0-9]', '', src.height))
else:
src_height = 1415
scale_factor = icon_size[1] / src_height
if path.startswith('Makeup'):
scale_factor = scale_factor / 2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W293 blank line contains whitespace

if path.startswith('Makeup'):
x_to_center = (icon_size[0] / 2) - ((src_width * scale_factor) / 2)
svg = svg.move(x_to_center, src_height * scale_factor / 2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W293 blank line contains whitespace

@thelostone-mc
Copy link
Member

@kuhnchris could you resolve the stickler errors? ^_^

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #2968 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2968      +/-   ##
==========================================
- Coverage   29.78%   29.72%   -0.07%     
==========================================
  Files         180      180              
  Lines       13720    13728       +8     
  Branches     1839     1842       +3     
==========================================
- Hits         4086     4080       -6     
- Misses       9496     9510      +14     
  Partials      138      138
Impacted Files Coverage Δ
app/avatar/utils.py 16.66% <0%> (-0.63%) ⬇️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afda04c...0c42015. Read the comment docs.

@kuhnchris
Copy link
Contributor Author

Do I have to? Awww. 😭 Anyways, fix inbound!

@mbeacom mbeacom requested a review from a team November 28, 2018 20:30
Copy link
Contributor

@owocki owocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @kuhnchris

@gitcoinbot
Copy link
Member

⚡️ A *Helpotron* Kudos has been sent to @kuhnchris for this issue from @owocki. ⚡️

The sender had the following public comments:

the very first helpotron is yours!

Nice work @kuhnchris!
Your Kudos has automatically been sent in the ETH address we have on file.

@owocki owocki merged commit 14d1e21 into gitcoinco:master Nov 30, 2018
@kuhnchris kuhnchris deleted the patch-4 branch November 30, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants