-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ks contract versioning #2951
Ks contract versioning #2951
Changes from all commits
1bab5e2
a30b60a
4546003
ffa71b0
98489db
6855f95
278d5c8
a406244
6acef6e
59018a2
eb21f08
22fe0d7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Generated by Django 2.1.2 on 2018-11-26 16:52 | ||
|
||
from django.db import migrations | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('dashboard', '0112_auto_20181107_1809'), | ||
('dashboard', '0116_merge_20181115_2252'), | ||
] | ||
|
||
operations = [ | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Generated by Django 2.1.2 on 2018-11-26 16:52 | ||
|
||
from django.db import migrations | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('grants', '0006_auto_20181121_1646'), | ||
] | ||
|
||
operations = [ | ||
migrations.AlterModelOptions( | ||
name='grant', | ||
options={'ordering': ['-created_on']}, | ||
), | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Generated by Django 2.1.2 on 2018-11-26 20:34 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('grants', '0007_auto_20181126_1652'), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name='grant', | ||
name='contract_version', | ||
field=models.DecimalField(decimal_places=0, default=0, help_text='The contract version the Grant.', max_digits=3), | ||
), | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,6 +112,12 @@ class Meta: | |
default='0x0', | ||
help_text=_('The contract address of the Grant.'), | ||
) | ||
contract_version = models.DecimalField( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we include a process for handling the ABI based on contract version, so it outputs the appropriate static URL or a given contract version..? Also, we are we using a decimalfield if Can we switch this to a charfield? If we're going by semantic versioning, decimalfield won't make sense: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
this makes sense to me
as does this |
||
default=0, | ||
decimal_places=0, | ||
max_digits=3, | ||
help_text=_('The contract version the Grant.'), | ||
) | ||
transaction_hash = models.CharField( | ||
max_length=255, | ||
default='0x0', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SaptakS @thelostone-mc do these migrations look ok to you?