Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor landing page for grants #2944

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented Nov 26, 2018

Description

Refactoring landing page based on @willsputra design.

screenshot-localhost-8000-2018 11 26-17-31-24

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

Refs: #2025 (comment)

@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #2944 into grants will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           grants    #2944   +/-   ##
=======================================
  Coverage   17.05%   17.05%           
=======================================
  Files         175      175           
  Lines       13864    13864           
  Branches     1813     1813           
=======================================
  Hits         2365     2365           
+ Misses      11491    11490    -1     
- Partials        8        9    +1
Impacted Files Coverage Δ
app/grants/views.py 0% <ø> (ø) ⬆️
...eting/management/commands/assemble_leaderboards.py 25.5% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5d869...7afdd3d. Read the comment docs.

@thelostone-mc
Copy link
Member

Fixed up mobile responsiveness and LGTM ^_^
Thanks @octavioamu for catching that :P

untitled

@thelostone-mc thelostone-mc merged commit 24e698b into gitcoinco:grants Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants